MIME-Version: 1.0
In-Reply-To: <1373343147.9458.25.camel@joe-AO722>
References: <1373152062-28164-1-git-send-email-wedsonaf@gmail.com>
	<1373173169.1943.1.camel@joe-AO722>
	<CANeycqqGYKs+Q+_6zpjfdQ+y-QBZLD+jGdU9-YJi9XaYXyCv-w@mail.gmail.com>
	<1373343147.9458.25.camel@joe-AO722>
Date: Mon, 8 Jul 2013 21:58:20 -0700
Message-ID: <CANeycqoHsRqCU4BSkPYK5O++ciShAmFcpEx+D3XUha7kukU0bQ@mail.gmail.com>
Subject: Re: [PATCH] lib: One less subtraction in binary search iterations.
From: Wedson Almeida Filho <wedsonaf@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, Tim Abbott <tabbott@ksplice.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 814
Lines: 21

On Mon, Jul 8, 2013 at 9:12 PM, Joe Perches <joe@perches.com> wrote:
>> There is no functional change, but this change eliminates a subtraction that
>> the compiler doesn't optimize out (as of gcc 4.7.3).
>
> That's flatly incorrect.

I'm not arguing this. I in fact already acknowledged that the
statement is incorrect.

> I don't mind if you change it, for just the reason
> you wrote, but you still have to now say under what
> conditions the test works and when it doesn't.

Yes, I'll update and respin the patch as also suggested by Rusty.

Thanks for the review.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/