Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971Ab3GIFp0 (ORCPT ); Tue, 9 Jul 2013 01:45:26 -0400 Received: from g5t0008.atlanta.hp.com ([15.192.0.45]:14363 "EHLO g5t0008.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185Ab3GIFpX (ORCPT ); Tue, 9 Jul 2013 01:45:23 -0400 Message-ID: <51DBA312.7090908@hp.com> Date: Tue, 09 Jul 2013 13:43:46 +0800 From: ZhenHua User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20130117 Thunderbird/19.0 MIME-Version: 1.0 To: Bjorn Helgaas CC: "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Li, Zhen-Hua" Subject: Re: [PATCH 1/1] ia64/pci: set mmio decoding on for some host bridge References: <1373242613-4603-1-git-send-email-zhen-hual@hp.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2470 Lines: 64 Hi Bjorn, Thank you for reviewing this patch. I have created a new one and sent it out. And your questions are answered in that new wmail. Regards ZhenHua On 07/09/2013 04:35 AM, Bjorn Helgaas wrote: > On Sun, Jul 7, 2013 at 6:16 PM, Li, Zhen-Hua wrote: >> On some IA64 platforms with intel PCI bridge, for example, HP BL890c i2 >> with Intel Corporation 5520/5500/X58 I/O Hub PCI Express Root Port, >> when kernel tries to disable the mmio decoding on the PCI bridge devices, >> kernel may crash. >> >> And in the comment of function quirk_mmio_always_on, it also says: >> "But doing so (disable the mmio decoding) may cause problems on host bridge >> and perhaps other key system devices" >> >> So, for these PCI bridges, dev->mmio_always_on bit should be set to 1. >> >> >> Signed-off-by: Li, Zhen-Hua >> --- >> drivers/pci/quirks.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c >> index e85d230..24b8024 100644 >> --- a/drivers/pci/quirks.c >> +++ b/drivers/pci/quirks.c >> @@ -44,6 +44,21 @@ static void quirk_mmio_always_on(struct pci_dev *dev) >> DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_ANY_ID, PCI_ANY_ID, >> PCI_CLASS_BRIDGE_HOST, 8, quirk_mmio_always_on); >> >> +#ifdef CONFIG_IA64 >> +/* >> + * On some IA64 platforms, for some intel PCI bridge devices, for example, >> + * the Intel Corporation 5520/5500/X58 I/O Hub PCI Express Root Port, >> + * disable the mmio decoding on these devices may cause system crash. >> + * So dev->mmio_always_on bit should be set to 1. >> + */ >> +static void quirk_mmio_on_intel_pcibridge(struct pci_dev *dev) >> +{ >> + dev->mmio_always_on = 1; >> +} >> +DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_ANY_ID, PCI_ANY_ID, >> + PCI_CLASS_BRIDGE_PCI, 8, quirk_mmio_on_intel_pcibridge); >> +#endif > The changelog and comment suggest an issue specific to Intel > 5520/5500/X58, but the patch sets mmio_always_on for *all* PCI > bridges. > > It claims to be specific to ia64 (and is only compiled there), but the > chipset is also used for x86. You need to explain why the problem > only affects ia64. > > Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/