Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754109Ab3GIOxr (ORCPT ); Tue, 9 Jul 2013 10:53:47 -0400 Received: from am1ehsobe005.messaging.microsoft.com ([213.199.154.208]:35304 "EHLO am1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753948Ab3GIOxe (ORCPT ); Tue, 9 Jul 2013 10:53:34 -0400 X-Forefront-Antispam-Report: CIP:62.221.5.235;KIP:(null);UIP:(null);IPV:NLI;H:xir-gw1;RD:unknown-62-221-5-235.ipspace.xilinx.com;EFVD:NLI X-SpamScore: 0 X-BigFish: VPS0(zzbb2dI98dI9371I1dbaI1432I4015Ide40hzz1f42h1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6hzzz2fh95h668h839hd24hf0ah119dh1288h12a5h12bdh137ah1441h1504h1537h153bh162dh1631h1758h18e1h190ch1946h19b4h19b5h19c3h1b0ah1bceh1be0h1d0ch1d2eh1d3fh1dfeh1dffh34h19b6n1155h192ch) Date: Tue, 9 Jul 2013 16:53:25 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Mark Brown CC: Michal Simek , Michal Simek , , linux-spi , Grant Likely , Subject: Re: [PATCH v1 3/4] spi/xilinx: Simplify irq allocation References: <20130708144930.GG27646@sirena.org.uk> <51DADF3E.1000802@monstr.eu> <20130708162642.GM27646@sirena.org.uk> <51DC1AF1.3090401@monstr.eu> <20130709144704.GY27646@sirena.org.uk> In-Reply-To: <20130709144704.GY27646@sirena.org.uk> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2CPXEQERUWJVTAQBQSBFQ" X-RCIS-Action: ALLOW Message-ID: X-OriginatorOrg: xilinx.com X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2008 Lines: 79 ------enig2CPXEQERUWJVTAQBQSBFQ Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 07/09/2013 04:47 PM, Mark Brown wrote: > On Tue, Jul 09, 2013 at 04:15:13PM +0200, Michal Simek wrote: > = >> 4. spi_master_release() >> 5. devres_release() with irq > = >> If interrupt happends between 4 and 5 than it can be the problem. >> Do I understand you correctly? > = > Yes. great. > = >> If this is problematic case we can disable local and global interrupts >> and add it between 2 and 3 or 3-4. >> /* Disable all the interrupts just in case */ >> xspi->write_fn(0, regs_base + XIPIF_V123B_IIER_OFFSET); >> /* Disable the global IPIF interrupt */ >> xspi->write_fn(0, regs_base + XIPIF_V123B_DGIER_OFFSET); > = >> What do you think about this solution? > = > That's fine, though if just manually freeing the IRQ works that's also > OK... yeah. >> I have also tried to run one thing with and without this patch >> and the results are below. > = >> When I add this irq disable function between 1 and 2 then >> module removing stucks. > = > You'll need to wait until the device is quiesced at least if it's > relying on the interrupt to complete operations. > = ok. Will send v2 of this patch. Thanks, Michal ------enig2CPXEQERUWJVTAQBQSBFQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlHcI+UACgkQykllyylKDCHHcQCePC7ImYcQwBUODfLFTpgeZOz6 ciMAmQEFccuRrgh3/vEQXW7vloz4K0Gh =ktlc -----END PGP SIGNATURE----- ------enig2CPXEQERUWJVTAQBQSBFQ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/