Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754153Ab3GIPGK (ORCPT ); Tue, 9 Jul 2013 11:06:10 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:56951 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753630Ab3GIPGH (ORCPT ); Tue, 9 Jul 2013 11:06:07 -0400 MIME-Version: 1.0 In-Reply-To: References: <20130702192749.A2E7E660D9B@gitolite.kernel.org> <20130706221401.GA3652@redhat.com> <20130706223003.GA10697@kroah.com> Date: Tue, 9 Jul 2013 23:06:05 +0800 Message-ID: Subject: Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly From: Ming Lei To: Takashi Iwai Cc: Greg KH , Dave Jones , Linux Kernel Mailing List Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 35 On Tue, Jul 9, 2013 at 10:45 PM, Takashi Iwai wrote: > At Tue, 9 Jul 2013 22:39:36 +0800, > Ming Lei wrote: >> >> On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: >> > At Tue, 9 Jul 2013 16:43:30 +0800, >> >> Actually from view of distribution, dell rbu has to be compiled in, then >> >> no code size can be saved any more, which means looks the introduced >> >> option in this patch isn't necessary. >> > >> > Well, but it means that there is no way not to compile user-helper >> > mode code in firmware_class.c. In other words, in which condition, >> > request_firmware_user() will be compiled? >> >> It can be always compiled in. Basically dell rbu is always enabled in >> distributions, which means the user helper code has to be compiled in. > > But how non-distro kernel disables this being built-in...? > Or do you suggest to enable the user-helper codes always built, no > matter whether it's used or not? The only cost of built-in user helper code is ~6Kbytes code on my armv7 box. If the 6KB memory does mater for this non-distro kernel, we can introduce more options. Thanks, -- Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/