Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754181Ab3GIPMA (ORCPT ); Tue, 9 Jul 2013 11:12:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47861 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113Ab3GIPL7 (ORCPT ); Tue, 9 Jul 2013 11:11:59 -0400 Date: Tue, 09 Jul 2013 17:13:16 +0200 Message-ID: From: Takashi Iwai To: Ming Lei Cc: Greg KH , Dave Jones , Linux Kernel Mailing List Subject: Re: dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly In-Reply-To: References: <20130702192749.A2E7E660D9B@gitolite.kernel.org> <20130706221401.GA3652@redhat.com> <20130706223003.GA10697@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1667 Lines: 41 At Tue, 9 Jul 2013 23:06:05 +0800, Ming Lei wrote: > > On Tue, Jul 9, 2013 at 10:45 PM, Takashi Iwai wrote: > > At Tue, 9 Jul 2013 22:39:36 +0800, > > Ming Lei wrote: > >> > >> On Tue, Jul 9, 2013 at 9:32 PM, Takashi Iwai wrote: > >> > At Tue, 9 Jul 2013 16:43:30 +0800, > >> >> Actually from view of distribution, dell rbu has to be compiled in, then > >> >> no code size can be saved any more, which means looks the introduced > >> >> option in this patch isn't necessary. > >> > > >> > Well, but it means that there is no way not to compile user-helper > >> > mode code in firmware_class.c. In other words, in which condition, > >> > request_firmware_user() will be compiled? > >> > >> It can be always compiled in. Basically dell rbu is always enabled in > >> distributions, which means the user helper code has to be compiled in. > > > > But how non-distro kernel disables this being built-in...? > > Or do you suggest to enable the user-helper codes always built, no > > matter whether it's used or not? > > The only cost of built-in user helper code is ~6Kbytes code on my armv7 > box. > > If the 6KB memory does mater for this non-distro kernel, we can introduce > more options. Well, if it doesn't matter, we don't need CONFIG_FW_LOADER_USER_HELPER either. The goal of this option is to kill the user helper code, not intended as a workaround for 60 seconds stall. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/