Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157Ab3GIPYn (ORCPT ); Tue, 9 Jul 2013 11:24:43 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:36347 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751717Ab3GIPYk (ORCPT ); Tue, 9 Jul 2013 11:24:40 -0400 Date: Tue, 9 Jul 2013 11:24:39 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Roger Quadros cc: gregkh@linuxfoundation.org, , Subject: Re: [PATCH] USB: EHCI: Fix resume signalling on remote wakeup In-Reply-To: <1373378630-2126-1-git-send-email-rogerq@ti.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 37 On Tue, 9 Jul 2013, Roger Quadros wrote: > Set the ehci->resuming flag for the port we receive a remote > wakeup on so that resume signalling can be completed. > > Without this, the root hub timer will not fire again to check > if the resume was completed and there will be a never-ending wait on > on the port. > > This effect is only observed if the HUB IRQ IN does not come after we > have initiated the port resume. > > Signed-off-by: Roger Quadros > --- > drivers/usb/host/ehci-hub.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c > index 9ab4a4d..ca6289b 100644 > --- a/drivers/usb/host/ehci-hub.c > +++ b/drivers/usb/host/ehci-hub.c > @@ -858,6 +858,7 @@ static int ehci_hub_control ( > ehci->reset_done[wIndex] = jiffies > + msecs_to_jiffies(20); > usb_hcd_start_port_resume(&hcd->self, wIndex); > + set_bit(wIndex, &ehci->resuming_ports); > /* check the port again */ > mod_timer(&ehci_to_hcd(ehci)->rh_timer, > ehci->reset_done[wIndex]); Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/