Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754068Ab3GIXjg (ORCPT ); Tue, 9 Jul 2013 19:39:36 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:36238 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754870Ab3GIXjd (ORCPT ); Tue, 9 Jul 2013 19:39:33 -0400 From: "Rafael J. Wysocki" To: Mika Westerberg Cc: ACPI Devel Maling List , Bjorn Helgaas , LKML , Linux PCI , Yinghai Lu , Jiang Liu Subject: Re: [RFC][PATCH 5/8] ACPI / hotplug / PCI: Unified notify handler for hotplug events Date: Wed, 10 Jul 2013 01:49:19 +0200 Message-ID: <2332413.CRuyXNEmFc@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <20130709093045.GJ4898@intel.com> References: <26431283.HJCKsss0rt@vostro.rjw.lan> <1475924.SZkPqZAdKY@vostro.rjw.lan> <20130709093045.GJ4898@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1195 Lines: 33 On Tuesday, July 09, 2013 12:30:45 PM Mika Westerberg wrote: > On Tue, Jul 09, 2013 at 02:19:04AM +0200, Rafael J. Wysocki wrote: > > Index: linux-pm/drivers/pci/hotplug/acpiphp.h > > =================================================================== > > --- linux-pm.orig/drivers/pci/hotplug/acpiphp.h > > +++ linux-pm/drivers/pci/hotplug/acpiphp.h > > @@ -137,6 +137,7 @@ struct acpiphp_context { > > acpi_handle handle; > > struct acpiphp_func *func; > > struct acpiphp_bridge *bridge; > > + bool handler_for_func:1; > > Hmm, should it be just plain: > > bool handler_for_func; > > ? What's the reason using bitfields for bool? If there are more of them, they can be stored together in one int (they are unsigned int under the hood). I this particular case it doesn't matter and one of subsequent patches will remove that field anyway. :-) > > }; -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/