Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754193Ab3GJCSR (ORCPT ); Tue, 9 Jul 2013 22:18:17 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:46452 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753627Ab3GJCSQ (ORCPT ); Tue, 9 Jul 2013 22:18:16 -0400 Message-ID: <51DCC426.3010606@gmail.com> Date: Wed, 10 Jul 2013 10:17:10 +0800 From: Chen Gang F T User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Rusty Russell CC: Chen Gang , khali@linux-fr.org, David.Woodhouse@intel.com, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] kernel/params.c: print failure information instead of 'KOBJ_ADD' to user space, when sysfs_create_file() fails. References: <51DB8597.4090101@asianux.com> <87y59gcg17.fsf@rustcorp.com.au> In-Reply-To: <87y59gcg17.fsf@rustcorp.com.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1930 Lines: 61 On 07/09/2013 04:07 PM, Rusty Russell wrote: > Chen Gang writes: >> When sysfs_create_file() fails, recommend to print the related failure >> information. And it is useless to still 'KOBJ_ADD' to user space. >> >> Signed-off-by: Chen Gang > > sysfs_create_file() should not fail during boot, should it? > Hmm..., please reference locate_module_kobject() in "kernel/params.c", which is an '__init' function, and also call sysfs_create_file(), it processes the related error. So I recommend to get the check too in version_sysfs_builtin(). Thanks. > Cheers, > Rusty. > >> --- >> kernel/params.c | 8 +++++++- >> 1 files changed, 7 insertions(+), 1 deletions(-) >> >> diff --git a/kernel/params.c b/kernel/params.c >> index 440e65d..f5299c1 100644 >> --- a/kernel/params.c >> +++ b/kernel/params.c >> @@ -845,7 +845,13 @@ static void __init version_sysfs_builtin(void) >> mk = locate_module_kobject(vattr->module_name); >> if (mk) { >> err = sysfs_create_file(&mk->kobj, &vattr->mattr.attr); >> - kobject_uevent(&mk->kobj, KOBJ_ADD); >> + if (err) >> + printk(KERN_WARNING >> + "%s (%d): sysfs_create_file fail for %s, err: %d\n", >> + __FILE__, __LINE__, >> + vattr->module_name, err); >> + else >> + kobject_uevent(&mk->kobj, KOBJ_ADD); >> kobject_put(&mk->kobj); >> } >> } >> -- >> 1.7.7.6 > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/