Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754225Ab3GJKBC (ORCPT ); Wed, 10 Jul 2013 06:01:02 -0400 Received: from mx-out.ocsa-data.net ([194.36.166.37]:61241 "EHLO mx-out.ocsa-data.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752621Ab3GJKBA (ORCPT ); Wed, 10 Jul 2013 06:01:00 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 10 Jul 2013 12:00:57 +0200 From: Yann Droneaud To: Ben Myers Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com, ydroneaud@opteya.com Subject: Re: [PATCH 10/13] xfs: use =?UTF-8?Q?get=5Funused=5Ffd=5Fflags=28?= =?UTF-8?Q?=30=29=20instead=20of=20get=5Funused=5Ffd=28=29?= Organization: OPTEYA In-Reply-To: <20130709205321.GV20932@sgi.com> References: <8d21b76c621dbfc59b2dbbfc933f96170835304d.1372777600.git.ydroneaud@opteya.com> <20130708224133.GA23250@sgi.com> <20130709205321.GV20932@sgi.com> Message-ID: <70a3a6971c3127226563e9538ae53bec@meuh.org> User-Agent: Roundcube Webmail/0.9.2 X-abuse-contact: abuse@ocsa-data.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1830 Lines: 62 Hi, Le 09.07.2013 22:53, Ben Myers a écrit : > On Mon, Jul 08, 2013 at 05:41:33PM -0500, Ben Myers wrote: >> On Tue, Jul 02, 2013 at 06:39:34PM +0200, Yann Droneaud wrote: >> > diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c >> > index 5e99968..dc5b659 100644 >> > --- a/fs/xfs/xfs_ioctl.c >> > +++ b/fs/xfs/xfs_ioctl.c >> > @@ -248,7 +248,7 @@ xfs_open_by_handle( >> > goto out_dput; >> > } >> > >> > - fd = get_unused_fd(); >> > + fd = get_unused_fd_flags(0); >> >> O_CLOEXEC should be fine in this case. >> >> Reviewed-by: Ben Myers > > Applied at git://oss.sgi.com/xfs/xfs.git. Looks like I was wrong about > O_CLOEXEC being ok here. There may be applications which > open_by_handle then > fork/exec and expect to still be able to use that file descriptor. > OK, it's very important to not cause regression here. For the record, xfs_open_by_handle() is not related to open_by_handle_at() syscall. It's an ioctl (XFS_IOC_OPEN_BY_HANDLE) which is used by xfsprogs's libhandle in functions open_by_fshandle() and open_by_handle(). http://sources.debian.net/src/xfsprogs/3.1.9/libhandle/handle.c?hl=284#L284 http://sources.debian.net/src/xfsprogs/3.1.9/libhandle/handle.c?hl=308#L308 According to codesearch.debian.org, libhandle's open_by_handle() is only used by xfsdump http://sources.debian.net/src/xfsdump/3.1.1/restore/tree.c?hl=2534#L2534 So there's no many *known* users of this features ... but it's more important not to break *unknown* users of it. BTW, thanks for the review and applying. Regards. -- Yann Droneaud OPTEYA -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/