Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754256Ab3GJKBU (ORCPT ); Wed, 10 Jul 2013 06:01:20 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:58693 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754079Ab3GJKBT (ORCPT ); Wed, 10 Jul 2013 06:01:19 -0400 Date: Wed, 10 Jul 2013 11:00:20 +0100 From: Mark Brown To: Richard Genoud Cc: Nicolas Ferre , Liam Girdwood , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Bo Shen , Lars-Peter Clausen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org Message-ID: <20130710100020.GA24508@sirena.org.uk> References: <1373372929-17800-1-git-send-email-richard.genoud@gmail.com> <1373379933-32749-1-git-send-email-richard.genoud@gmail.com> <1373379933-32749-2-git-send-email-richard.genoud@gmail.com> <20130709145917.GA27646@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline In-Reply-To: X-Cookie: You are always busy. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 193.120.41.118 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 1/7] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2155 Lines: 53 --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 10, 2013 at 11:25:37AM +0200, Richard Genoud wrote: > 2013/7/9 Mark Brown : > > Shouldn't the SSC driver be enforcing this constraint if it comes from > > the SSC hardware? If the clock is reprogrammable the usual convention > > for drivers is to not constrain if the clock is set to zero so a machine > > driver could remove the constraint. > Actually, my comment is buggy here (or at least, unrelated to the > authorized rates). > The "MCLK_RATE" is the master clock of the wm8731 codec (a 12.288MHz crystal). > According to the datasheet of wm8731, when a 12.288 crystal is used, > the authorized rates are 8, 32, 48 and 96kHz (I have to remove 16 and > 64kHz). > So, is this the right place for the rates ? No, the CODEC driver should be enforcing the restrictions if that's where they come from. --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJR3TCsAAoJELSic+t+oim96l4QAIBNdsDlUYqOzzE2DqS09ARC LGwnmmxhDThgOEgKOlgaRVz215VBl7h+IB77pwGYwesWkMJlW7PhC3ES2fPmM/9i aRkDx+2DKeRPjNJS2uvfmKo+ueF4PQEBkCsnHmbKphgmUA+LIkzp4bRarzKxqOqE uL7g682JHdUvD3wYSvVg2w8AoOCRZzLsdIUNeIkK8WKLcrK9OWBJwKagO5JpF1m7 ZInX+d+5u0Sf13wOFk41fEtMKVzGKUuuji6HaPX4KUJsHufEHHLfhpE1Lan0Ag8y g2/e+7g89QNIyJ9gt8SCTI0yf2B7ObdIfnzct++S5puhAlsOAgQ0/imPXtFIGQt8 w9ezl0Az8EcLkiU9U3/uEUT7Jcd6wi9nBaTCdnv3IexxJbO/JEs+K+qrSlwi9e/H q8oPbw0Q9iJ3C2BLMVsVizezwpOo5bPbg5Xh7wZwroe5Ddf+6N2HpmAIn9HgbWne yDC++oc/+xw7NWXLMUE0ZCSvCs7ebqoI37HAcM6638foCIP9Pe12jAJqmfRvpGfG kSLeKy9cvuATNYySk/8iPPHAbh0Vi6ITZtjvcTKYt86nmKvpsD84bEaSihZD3GC3 hk5iTG2oYdImrGGnzLwOpazpcm0aPOhB5YRB7xzoyQmpzZWXzpyOYpweODnd3A8l ScFk6Lu0rf3WnDaFHOjV =bPxQ -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/