Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754460Ab3GJKt1 (ORCPT ); Wed, 10 Jul 2013 06:49:27 -0400 Received: from e06smtp10.uk.ibm.com ([195.75.94.106]:52988 "EHLO e06smtp10.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754435Ab3GJKtZ (ORCPT ); Wed, 10 Jul 2013 06:49:25 -0400 Message-ID: <51DD3C2E.50409@de.ibm.com> Date: Wed, 10 Jul 2013 12:49:18 +0200 From: Christian Borntraeger User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Alexander Graf CC: Dominik Dingel , Gleb Natapov , Paolo Bonzini , Heiko Carstens , Martin Schwidefsky , Cornelia Huck , Xiantao Zhang , Christoffer Dall , Marc Zyngier , Ralf Baechle , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] PF: Provide additional direct page notification References: <1373378207-10451-1-git-send-email-dingel@linux.vnet.ibm.com> <1373378207-10451-4-git-send-email-dingel@linux.vnet.ibm.com> <51DC33E7.1030404@de.ibm.com> <282EB214-206B-4A04-9830-D97679C9F4EC@suse.de> In-Reply-To: <282EB214-206B-4A04-9830-D97679C9F4EC@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13071010-4966-0000-0000-0000063FAB85 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1255 Lines: 31 On 10/07/13 12:39, Alexander Graf wrote: > > On 09.07.2013, at 18:01, Christian Borntraeger wrote: > >> On 09/07/13 15:56, Dominik Dingel wrote: >>> By setting a Kconfig option, the architecture can control when >>> guest notifications will be presented by the apf backend. >>> So there is the default batch mechanism, working as before, where the vcpu thread >>> should pull in this information. On the other hand there is now the direct >>> mechanism, this will directly push the information to the guest. >>> >>> Still the vcpu thread should call check_completion to cleanup leftovers, >>> that leaves most of the common code untouched. >>> >>> Signed-off-by: Dominik Dingel >> >> Acked-by: Christian Borntraeger >> for the "why". We want to use the existing architectured interface. > > Shouldn't this be a runtime option? This is an a) or b) depending on the architecture. So making this a kconfig option is the most sane approach no? Christian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/