Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754294Ab3GJMOO (ORCPT ); Wed, 10 Jul 2013 08:14:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44864 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753948Ab3GJMOM (ORCPT ); Wed, 10 Jul 2013 08:14:12 -0400 Date: Wed, 10 Jul 2013 15:15:21 +0300 From: "Michael S. Tsirkin" To: Ramkumar Ramachandra Cc: LKML , Rusty Russell Subject: Re: [PATCH 1/2] virtio tools: strip bad include-path from Makefile Message-ID: <20130710121521.GB11386@redhat.com> References: <1373453820-22517-1-git-send-email-artagnon@gmail.com> <1373453820-22517-2-git-send-email-artagnon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373453820-22517-2-git-send-email-artagnon@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1645 Lines: 40 On Wed, Jul 10, 2013 at 04:26:59PM +0530, Ramkumar Ramachandra wrote: > CFLAGS contains a mysterious "-I ../../usr/include", but no such path > exists in the linux tree. The line was originally introduced in > 4e53f78e (tools/virtio: virtio_test tool, 2010-11-29), but no such path > existed in the tree even then. > > Cc: Michael S. Tsirkin > Cc: Rusty Russell > Signed-off-by: Ramkumar Ramachandra NACK It exists if you do make headers_install. So it's handy for old distos where userspace headers don't exist or are out of date. > --- > tools/virtio/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/virtio/Makefile b/tools/virtio/Makefile > index 3187c62..53623c6 100644 > --- a/tools/virtio/Makefile > +++ b/tools/virtio/Makefile > @@ -3,7 +3,7 @@ test: virtio_test vringh_test > virtio_test: virtio_ring.o virtio_test.o > vringh_test: vringh_test.o vringh.o virtio_ring.o > > -CFLAGS += -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign -fno-strict-overflow -fno-strict-aliasing -fno-common -MMD -U_FORTIFY_SOURCE > +CFLAGS += -g -O2 -Wall -I. -Wno-pointer-sign -fno-strict-overflow -fno-strict-aliasing -fno-common -MMD -U_FORTIFY_SOURCE > vpath %.c ../../drivers/virtio ../../drivers/vhost > mod: > ${MAKE} -C `pwd`/../.. M=`pwd`/vhost_test > -- > 1.8.3.2.736.g869de25 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/