Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240Ab3GJMYq (ORCPT ); Wed, 10 Jul 2013 08:24:46 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:54973 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753758Ab3GJMYp (ORCPT ); Wed, 10 Jul 2013 08:24:45 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 72.84.113.162 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18V3uKcIVD/qdP6a9bkIXh/pTO3/eL4LDs= Date: Wed, 10 Jul 2013 08:24:33 -0400 From: Jason Cooper To: Haojian Zhuang Cc: Neil Zhang , Grant Likely , Bergmann Arnd , devicetree-discuss@lists.ozlabs.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell' Message-ID: <20130710122433.GO11908@titan.lakedaemon.net> References: <1373352166-10064-1-git-send-email-zhangwm@marvell.com> <1373352166-10064-2-git-send-email-zhangwm@marvell.com> <20130709124900.GG11908@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3369 Lines: 66 On Wed, Jul 10, 2013 at 04:19:46PM +0800, Haojian Zhuang wrote: > On Tue, Jul 9, 2013 at 8:49 PM, Jason Cooper wrote: > > Neil, > > > > On Tue, Jul 09, 2013 at 02:42:44PM +0800, Neil Zhang wrote: > >> The documented vendor prefix for Marvell is 'marvell', not 'mrvl', so > >> let's change it. > >> > >> Signed-off-by: Neil Zhang > >> --- > >> .../devicetree/bindings/arm/mrvl/intc.txt | 16 +++--- > >> .../devicetree/bindings/arm/mrvl/mrvl.txt | 6 +- > >> .../devicetree/bindings/arm/mrvl/timer.txt | 4 +- > >> Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 14 +++--- > >> .../devicetree/bindings/mmc/sdhci-pxa.txt | 8 ++-- > >> .../devicetree/bindings/rtc/sa1100-rtc.txt | 4 +- > >> .../devicetree/bindings/serial/mrvl-serial.txt | 2 +- > >> arch/arm/boot/dts/mmp2-brownstone.dts | 2 +- > >> arch/arm/boot/dts/mmp2.dtsi | 56 ++++++++++---------- > >> arch/arm/boot/dts/pxa168-aspenite.dts | 2 +- > >> arch/arm/boot/dts/pxa168.dtsi | 24 ++++---- > >> arch/arm/boot/dts/pxa2xx.dtsi | 16 +++--- > >> arch/arm/boot/dts/pxa3xx.dtsi | 2 +- > >> arch/arm/boot/dts/pxa910-dkb.dts | 2 +- > >> arch/arm/boot/dts/pxa910.dtsi | 27 +++++----- > >> arch/arm/mach-mmp/irq.c | 16 +++--- > >> arch/arm/mach-mmp/mmp-dt.c | 28 +++++----- > >> arch/arm/mach-mmp/mmp2-dt.c | 16 +++--- > >> arch/arm/mach-mmp/time.c | 2 +- > >> arch/arm/mach-pxa/pxa-dt.c | 14 +++--- > >> drivers/i2c/busses/i2c-pxa.c | 10 ++-- > >> drivers/mmc/host/sdhci-pxav2.c | 4 +- > >> drivers/mmc/host/sdhci-pxav3.c | 4 +- > >> drivers/rtc/rtc-sa1100.c | 4 +- > >> drivers/tty/serial/pxa.c | 4 +- > >> 25 files changed, 144 insertions(+), 143 deletions(-) > > > > I agree with the need to change, however, this has been in the binding > > documentation since v3.5. I wish we had caught this when we decided > > against using stock ticker symbols (not all stock markets use > > alphabetical abbreviated names, not all companies are listed on any > > stock exchange). > > > > To do this properly, the drivers are going to have to be compatible with > > the old and the new names, and the binding docs updated to reflect the > > legacy name and the preferred name. > > > > It's better to only use the new names. In the dts{i}, yes. But we don't want to break systems in the field with "mrvl,..." compatible strings. Therefore, at least the drivers need an extra compatible string to support "mrvl,...". If it had just been since v3.9, it'd be different/simpler. However, several vendors have opted to use kernels newer than v3.5, which makes this scenario a real possibility. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/