Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754481Ab3GJNZk (ORCPT ); Wed, 10 Jul 2013 09:25:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487Ab3GJNZj (ORCPT ); Wed, 10 Jul 2013 09:25:39 -0400 Date: Wed, 10 Jul 2013 16:26:46 +0300 From: "Michael S. Tsirkin" To: Ramkumar Ramachandra Cc: LKML , Rusty Russell Subject: Re: [PATCH 1/2] virtio tools: strip bad include-path from Makefile Message-ID: <20130710132646.GA13131@redhat.com> References: <1373453820-22517-1-git-send-email-artagnon@gmail.com> <1373453820-22517-2-git-send-email-artagnon@gmail.com> <20130710121521.GB11386@redhat.com> <20130710124253.GA12645@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 22 On Wed, Jul 10, 2013 at 06:52:09PM +0530, Ramkumar Ramachandra wrote: > Michael S. Tsirkin wrote: > > This is usespace code so it needs the cleaned-up version from > > usr/include, not the internal kernel one. > > Right, thanks for clearing that up. However, it does seem to depend > on some code in /include in the linux tree. From > tools/virtio/linux/virtio_ring.h: > > #include "../../../include/linux/virtio_ring.h" Yes, this is because we take some kernel bits and compile as userspace. But it's fragile and it only works for specific headers. -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/