Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754997Ab3GJQZL (ORCPT ); Wed, 10 Jul 2013 12:25:11 -0400 Received: from gmmr2.centrum.cz ([46.255.227.252]:57034 "EHLO gmmr2.centrum.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754864Ab3GJQZJ (ORCPT ); Wed, 10 Jul 2013 12:25:09 -0400 To: =?utf-8?q?Michal_Hocko?= Subject: =?utf-8?q?Re=3A_=5BPATCH_for_3=2E2=5D_memcg=3A_do_not_trap_chargers_with_full_callstack_on_OOM?= Date: Wed, 10 Jul 2013 18:25:06 +0200 From: "azurIt" Cc: =?utf-8?q?Johannes_Weiner?= , , , =?utf-8?q?cgroups_mailinglist?= , =?utf-8?q?KAMEZAWA_Hiroyuki?= , References: <20130619132614.GC16457@dhcp22.suse.cz>, <20130622220958.D10567A4@pobox.sk>, <20130624201345.GA21822@cmpxchg.org>, <20130628120613.6D6CAD21@pobox.sk>, <20130705181728.GQ17812@cmpxchg.org>, <20130705210246.11D2135A@pobox.sk>, <20130705191854.GR17812@cmpxchg.org>, <20130708014224.50F06960@pobox.sk>, <20130709131029.GH20281@dhcp22.suse.cz>, <20130709151921.5160C199@pobox.sk> <20130709135450.GI20281@dhcp22.suse.cz> In-Reply-To: <20130709135450.GI20281@dhcp22.suse.cz> X-Mailer: Centrum Email 5.3 X-Priority: 3 X-Original-From: azurit@pobox.sk MIME-Version: 1.0 Message-Id: <20130710182506.F25DF461@pobox.sk> X-Maser: oho Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1604 Lines: 49 >> Now i realized that i forgot to remove UID from that cgroup before >> trying to remove it, so cgroup cannot be removed anyway (we are using >> third party cgroup called cgroup-uid from Andrea Righi, which is able >> to associate all user's processes with target cgroup). Look here for >> cgroup-uid patch: >> https://www.develer.com/~arighi/linux/patches/cgroup-uid/cgroup-uid-v8.patch >> >> ANYWAY, i'm 101% sure that 'tasks' file was empty and 'under_oom' was >> permanently '1'. > >This is really strange. Could you post the whole diff against stable >tree you are using (except for grsecurity stuff and the above cgroup-uid >patch)? Here are all patches which i applied to kernel 3.2.48 in my last test: http://watchdog.sk/lkml/patches3/ Patches marked as 7-* are from Johannes. I'm appling them in order except the grsecurity - it goes as first. azur >Btw. the bellow patch might help us to point to the exit path which >leaves wait_on_memcg without mem_cgroup_oom_synchronize: >--- >diff --git a/kernel/exit.c b/kernel/exit.c >index e6e01b9..ad472e0 100644 >--- a/kernel/exit.c >+++ b/kernel/exit.c >@@ -895,6 +895,7 @@ NORET_TYPE void do_exit(long code) > > profile_task_exit(tsk); > >+ WARN_ON(current->memcg_oom.wait_on_memcg); > WARN_ON(blk_needs_flush_plug(tsk)); > > if (unlikely(in_interrupt())) >-- >Michal Hocko >SUSE Labs > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/