Date: Wed, 10 Jul 2013 17:43:39 -0700 (PDT)
Message-Id: <20130710.174339.1202620552412048634.davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: hayeswang@realtek.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] r8169: add a new chip for RTL8411
From: David Miller <davem@davemloft.net>
In-Reply-To: <20130709230015.GA6843@electric-eye.fr.zoreil.com>
References: <1373274541-1095-1-git-send-email-hayeswang@realtek.com>
	<20130709.125305.1668056299963467935.davem@davemloft.net>
	<20130709230015.GA6843@electric-eye.fr.zoreil.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 884
Lines: 28

From: Francois Romieu <romieu@fr.zoreil.com>
Date: Wed, 10 Jul 2013 01:00:16 +0200

> David Miller <davem@davemloft.net> :
> [...]
>> Francois, please review.
> 
> The style is consistent with the driver.
> 
> The commit message may state that this 8411 chipset does not require
> any special action in rtl_link_chg_patch (whence differing from the
> previous "F" 8411).
> 
> Most of the code shared by rtl_hw_start_8168g_2 and rtl_hw_start_8411_2
> is already factored out. There is not much to win here.
> 
> The new RTL_GIGA_MAC_VER_XY id is added in the required places.
> 
> It builds.
> 
> It's fine.

Thanks for reviewing, applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/