Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755450Ab3GKAoD (ORCPT ); Wed, 10 Jul 2013 20:44:03 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37529 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755410Ab3GKAoA (ORCPT ); Wed, 10 Jul 2013 20:44:00 -0400 MIME-Version: 1.0 In-Reply-To: References: <1373391071-6312-1-git-send-email-dianders@chromium.org> <1373391071-6312-4-git-send-email-dianders@chromium.org> Date: Wed, 10 Jul 2013 17:43:58 -0700 X-Google-Sender-Auth: u3uUiNHGhXEesiMxVHgLbJSQwpM Message-ID: Subject: Re: [PATCH 3/5] mmc: dw_mmc: Add exynos resume callback to clear WAKEUP_INT From: Grant Grundler To: Doug Anderson Cc: Chris Ball , Olof Johansson , Jaehoon Chung , Seungwon Jeon , James Hogan , Grant Grundler , Alim Akhtar , Abhilash Kesavan , Tomasz Figa , Kukjin Kim , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1286 Lines: 35 On Tue, Jul 9, 2013 at 12:09 PM, Doug Anderson wrote: > Hi, > > On Tue, Jul 9, 2013 at 10:31 AM, Doug Anderson wrote: >> If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up >> looping around forever. >> >> Signed-off-by: Doug Anderson >> --- >> drivers/mmc/host/dw_mmc-exynos.c | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) > > Grant just pointed out that the WAKEUP_INT is supposed to only be > enabled if bits 8, 9, or 10 are 1. Our driver never sets those so we > _should_ never get a WAKEUP_INT. Bits 8-10 are marked as RESERVED on > the exynos5420 manual, so the current guess is that they're broken on > that silicon but that sometimes the interrupt fires anyway. > > In any case, it is still a reasonable thing to clear this interrupt at > wakeup if it has fired, even if we're on an exynos device without any > problems. I agree. Can add: Reviewed-by: Grant Grundler thanks, grant > > -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/