Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755279Ab3GKBX1 (ORCPT ); Wed, 10 Jul 2013 21:23:27 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:57675 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755025Ab3GKBX0 (ORCPT ); Wed, 10 Jul 2013 21:23:26 -0400 Message-ID: <51DE0799.1090905@atmel.com> Date: Thu, 11 Jul 2013 09:17:13 +0800 From: Bo Shen User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Jean-Christophe PLAGNIOL-VILLARD CC: Nicolas Ferre , , , , Subject: Re: [PATCH 2/3] arm: atmel: at91sam9n12: add qt1070 support References: <1373449869-5083-1-git-send-email-voice.shen@atmel.com> <1373449869-5083-3-git-send-email-voice.shen@atmel.com> <20130710143835.GG18012@ns203013.ovh.net> In-Reply-To: <20130710143835.GG18012@ns203013.ovh.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1745 Lines: 67 Hi J, On 7/10/2013 22:38, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:51 Wed 10 Jul , Bo Shen wrote: >> add qt1070 support on at91sam9n12ek board >> >> Signed-off-by: Bo Shen >> --- >> arch/arm/boot/dts/at91sam9n12ek.dts | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/arch/arm/boot/dts/at91sam9n12ek.dts b/arch/arm/boot/dts/at91sam9n12ek.dts >> index d59b70c..3acac62 100644 >> --- a/arch/arm/boot/dts/at91sam9n12ek.dts >> +++ b/arch/arm/boot/dts/at91sam9n12ek.dts >> @@ -40,6 +40,15 @@ >> >> i2c0: i2c@f8010000 { >> status = "okay"; >> + >> + qt1070: keyboard@1b { >> + compatible = "qt1070"; >> + reg = <0x1b>; >> + interrupt-parent = <&pioA>; >> + interrupts = <2 0x0>; > use the macro Thanks, I will use macro here. >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_qt1070_irq>; >> + }; >> }; >> >> i2c1: i2c@f8014000 { >> @@ -66,6 +75,13 @@ >> ; /* PA7 gpio CD pin pull up and deglitch */ >> }; >> }; >> + >> + qt1070 { >> + pinctrl_qt1070_irq: qt1070_irq { >> + atmel,pins = >> + ; /* PA2 GPIO with pull up deglith */ > drop the comment as we use macro OK, I will drop the comment >> + }; >> + }; >> }; >> >> spi0: spi@f0000000 { >> -- > > Best Regards, > J. > Best Regards, Bo Shen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/