Message-ID: <51DE1111.7040809@redhat.com>
Date: Thu, 11 Jul 2013 09:57:37 +0800
From: Dave Young <dyoung@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0
MIME-Version: 1.0
To: Matt Fleming <matt.fleming@intel.com>
CC: lkml <linux-kernel@vger.kernel.org>,
        Matthew Garrett <matthew.garrett@nebula.com>
Subject: Re: uefi boot hang (bisected)
References: <51DD00DB.3010107@redhat.com> <51DD553B.1080701@intel.com>
In-Reply-To: <51DD553B.1080701@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1303
Lines: 46

On 07/10/2013 08:36 PM, Matt Fleming wrote:
> On 10/07/13 07:36, Dave Young wrote:
>> Another problem is: With this patch applied I tried noefi boot, but
>> kernel paniced, looks like efivar_init depends on efi runtime. Below
>> patches works for me about noefi boot though I'm not sure if it's a
>> right fix, please review.
> 
> It makes more sense to check in efivars.c, since none of that file can
> function without runtime serivces.
> 
> Could you try the following patch?

It works, thanks for the patch.

Tested-by: Dave Young <dyoung@redhat.com>

> 
> ---
> 
> diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c
> index 8bd1bb6..8a7432a 100644
> --- a/drivers/firmware/efi/efivars.c
> +++ b/drivers/firmware/efi/efivars.c
> @@ -583,6 +583,9 @@ int efivars_sysfs_init(void)
>  	struct kobject *parent_kobj = efivars_kobject();
>  	int error = 0;
>  
> +	if (!efi_enabled(EFI_RUNTIME_SERVICES))
> +		return -ENODEV;
> +
>  	/* No efivars has been registered yet */
>  	if (!parent_kobj)
>  		return 0;
> 


-- 
Thanks
Dave


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/