Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755675Ab3GKHbH (ORCPT ); Thu, 11 Jul 2013 03:31:07 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:38001 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755671Ab3GKHbD (ORCPT ); Thu, 11 Jul 2013 03:31:03 -0400 Message-ID: <51DE5F1B.8080201@ti.com> Date: Thu, 11 Jul 2013 10:30:35 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Alan Stern CC: , , , , , , , , , Subject: Re: [PATCH 5/6] USB: Support wakeup IRQ for suspended controllers References: In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1310 Lines: 36 On 07/10/2013 10:08 PM, Alan Stern wrote: > On Wed, 10 Jul 2013, Roger Quadros wrote: > >> Some platforms e.g. ehci-omap can generate an interrupt >> (i.e. remote wakeup) even when the controller is suspended i.e. >> HW_ACCESSIBLE is cleared. >> >> Introduce a flag "has_wakeup_irq" in struct usb_hcd to indicate >> such cases. >> >> We tackle this case by disabling the IRQ, scheduling a >> hub resume and enabling back the IRQ after the controller has >> resumed. This ensures that the IRQ handler runs only after the >> controller is accessible. > > Oh yes, one more thing... > >> @@ -132,6 +134,7 @@ struct usb_hcd { >> unsigned wireless:1; /* Wireless USB HCD */ >> unsigned authorized_default:1; >> unsigned has_tt:1; /* Integrated TT in root hub */ >> + unsigned has_wakeup_irq:1; /* Can IRQ when suspended */ > > Please add a highly visible comment here, warning that has_wakeup_irq > should never be set on systems with shared IRQs. Having both would ... > well, it would indicate a really bad system design. > OK, will do. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/