Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755830Ab3GKHkG (ORCPT ); Thu, 11 Jul 2013 03:40:06 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:34394 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755671Ab3GKHkE (ORCPT ); Thu, 11 Jul 2013 03:40:04 -0400 Message-ID: <51DE6152.20406@atmel.com> Date: Thu, 11 Jul 2013 09:40:02 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Wolfram Sang , , David Miller CC: Subject: Re: [PATCH 08/12] drivers/net/ethernet/cadence: don't use devm_pinctrl_get_select_default() in probe References: <1373471889-18107-1-git-send-email-wsa@the-dreams.de> <1373471889-18107-8-git-send-email-wsa@the-dreams.de> In-Reply-To: <1373471889-18107-8-git-send-email-wsa@the-dreams.de> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1878 Lines: 63 On 10/07/2013 17:57, Wolfram Sang : > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for setting the default pins. Compile tested only. > > Acked-by: Linus Walleij (personally at LCE13) > Signed-off-by: Wolfram Sang Acked-by: Nicolas Ferre Thanks Wolfram. Bye, > --- > drivers/net/ethernet/cadence/at91_ether.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c > index 3f19571..bb5d63f 100644 > --- a/drivers/net/ethernet/cadence/at91_ether.c > +++ b/drivers/net/ethernet/cadence/at91_ether.c > @@ -29,7 +29,6 @@ > #include > #include > #include > -#include > > #include "macb.h" > > @@ -309,7 +308,6 @@ static int __init at91ether_probe(struct platform_device *pdev) > struct resource *regs; > struct net_device *dev; > struct phy_device *phydev; > - struct pinctrl *pinctrl; > struct macb *lp; > int res; > u32 reg; > @@ -319,15 +317,6 @@ static int __init at91ether_probe(struct platform_device *pdev) > if (!regs) > return -ENOENT; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) { > - res = PTR_ERR(pinctrl); > - if (res == -EPROBE_DEFER) > - return res; > - > - dev_warn(&pdev->dev, "No pinctrl provided\n"); > - } > - > dev = alloc_etherdev(sizeof(struct macb)); > if (!dev) > return -ENOMEM; > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/