Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756038Ab3GKMv0 (ORCPT ); Thu, 11 Jul 2013 08:51:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:43882 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755834Ab3GKMvZ convert rfc822-to-8bit (ORCPT ); Thu, 11 Jul 2013 08:51:25 -0400 Subject: Re: [PATCH 6/8] KVM: PPC: Add support for multiple-TCE hcalls Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=us-ascii From: Alexander Graf In-Reply-To: <1373546368.19894.87.camel@pasglop> Date: Thu, 11 Jul 2013 14:51:20 +0200 Cc: Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org, David Gibson , Paul Mackerras , Alex Williamson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <4133424D-B105-4CB1-A72A-4F47A6184DC7@suse.de> References: <1373123227-22969-1-git-send-email-aik@ozlabs.ru> <1373123227-22969-7-git-send-email-aik@ozlabs.ru> <51DC4228.7010607@suse.de> <51DCEA76.9070808@ozlabs.ru> <51DE3ECB.7080803@ozlabs.ru> <43E93931-F213-47CC-ADCF-D3A6D6BC4372@suse.de> <51DE8EE9.2000508@ozlabs.ru> <1373546368.19894.87.camel@pasglop> To: Benjamin Herrenschmidt X-Mailer: Apple Mail (2.1278) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 28 On 11.07.2013, at 14:39, Benjamin Herrenschmidt wrote: > On Thu, 2013-07-11 at 13:15 +0200, Alexander Graf wrote: >> And that's bad. Jeez, seriously. Don't argue this case. We enable new >> features individually unless we're 100% sure we can keep everything >> working. In this case an ENABLE_CAP doesn't hurt at all, because user >> space still needs to handle the hypercalls if it wants them anyways. >> But you get debugging for free for example. > > An ENABLE_CAP is utterly pointless. More bloat. But you seem to like > it :-) I don't like bloat usually. But Alexey even had an #ifdef DEBUG in there to selectively disable in-kernel handling of multi-TCE. Not calling ENABLE_CAP would give him exactly that without ugly #ifdefs in the kernel. Alex > > Ben. > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/