Message-ID: <51DEEAFE.506@linux.intel.com>
Date: Thu, 11 Jul 2013 10:27:26 -0700
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
MIME-Version: 1.0
To: Alexander Holler <holler@ahsoftware.de>
CC: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
        Jonathan Cameron <jic23@cam.ac.uk>,
        Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Subject: Re: [PATCH 0/4] iio: hid-sensor: add module alias for autoload
References: <1373445120-5407-1-git-send-email-holler@ahsoftware.de> <51DD7D78.2020506@linux.intel.com> <51DD848E.4050206@ahsoftware.de>
In-Reply-To: <51DD848E.4050206@ahsoftware.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1945
Lines: 52


On 07/10/2013 08:58 AM, Alexander Holler wrote:
> Am 10.07.2013 17:27, schrieb Srinivas Pandruvada:
>> Hi,
>>
>> There was no intention to prevent auto loading. Did you get chance to
>> test these changes?
>
> Sure, I always test patches before I send them out.
>
> Ok, I haven't tested the changes with the iio HID drivers (I don't 
> have any commercial HID sensor hub, so I've just compile tested these 
> patches here, double reading them), but I've tested the similiar 
> changes with a patch for rtc-hid-sensor-time I've send out yesterday. 
> (sorry, no link, lkml.org seems dead, just search for 
> "rtc-hid-sensor-time: add module alias")
>
> It works just fine. An example output is now
>
> Jul  9 19:27:21 dockstar3 kernel: [    5.124444] rtc_hid_sensor_time 
> HID-SENSOR-2000a0.0: milliseconds supported
> Jul  9 19:27:21 dockstar3 kernel: [    5.132864] rtc_hid_sensor_time 
> HID-SENSOR-2000a0.0: rtc core: setting system clock to 2013-07-09 
> 17:26:51:328000 UTC (1373390811)
> Jul  9 19:27:21 dockstar3 kernel: [    5.146105] rtc_hid_sensor_time 
> HID-SENSOR-2000a0.0: rtc core: registered hid-sensor-time as rtc0
>
> Before the output was e.g.
>
> HID-SENSOR-2000a0 HID-SENSOR-2000a0.0: rtc core: registered 
> hid-sensor-time as rtc0
>
> instead of the above with the descriptive rtc_hid_sensor_time.
<Agreed. This is better. >
> Automatic loading of modules works too and it works on ARM, Intel and 
> AMD as module or static linked. ;)
>
> Regards,
>
> Alexander Holler
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/