Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 8 Oct 2002 14:17:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 8 Oct 2002 14:17:27 -0400 Received: from phoenix.mvhi.com ([195.224.96.167]:45065 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id ; Tue, 8 Oct 2002 14:17:26 -0400 Date: Tue, 8 Oct 2002 19:23:06 +0100 From: Christoph Hellwig To: tytso@mit.edu Cc: linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net Subject: Re: [Ext2-devel] [RFC] [PATCH 2/4] Add extended attributes to ext2/3 Message-ID: <20021008192306.B12912@infradead.org> Mail-Followup-To: Christoph Hellwig , tytso@mit.edu, linux-kernel@vger.kernel.org, ext2-devel@lists.sourceforge.net References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from tytso@mit.edu on Tue, Oct 08, 2002 at 02:08:14PM -0400 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 28 On Tue, Oct 08, 2002 at 02:08:14PM -0400, tytso@mit.edu wrote: > > This is the second of four patches which add extended attribute support > to the ext2 and ext3 filesystems. Please comment and bleed. > > This patch creates a meta block cache which is utilized by the ext3 and > ext2 extended attribute patch (patches 3 and 4, respectively). This > cache allows directory blocks to be indexed by multiple keys. In the > case of the extended attribute patches, it is used to look up blocks by > both the block number and by the hash of the extended attributes. This > is extremely important to allow the sharing of acl's when stored as > extended attributes. Otherwise every single file would require its own, > separate, one block overhead to store then ACL, even though there might > be a large number of files that have the same ACL. The code doesn't really make ?ny sense outside ext2/ext3. I'd suggest you move it there instead of bloating every kernel with it unconditionally. __mb_cache_entry_in_lru() is buggy and can't work anymore now that akpm removed some list_head debugging. And please get rid of the LINUX_VERSION_CODE checks.. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/