Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757535Ab3GLK0q (ORCPT ); Fri, 12 Jul 2013 06:26:46 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:63578 "EHLO mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757244Ab3GLK0p (ORCPT ); Fri, 12 Jul 2013 06:26:45 -0400 Date: Fri, 12 Jul 2013 12:26:41 +0200 From: Ingo Molnar To: Valentina Manea Cc: x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, bhelgaas@google.com, gregkh@linuxfoundation.org, bin.gao@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/pci: fix checkpatch.pl indentation warnings Message-ID: <20130712102641.GA13675@gmail.com> References: <1373523787-8249-1-git-send-email-valentina.manea.m@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373523787-8249-1-git-send-email-valentina.manea.m@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 50 * Valentina Manea wrote: > This patch fixes warnings generated by checkpatch.pl > regarding indentation. > > Signed-off-by: Valentina Manea > --- > arch/x86/pci/mrst.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/pci/mrst.c b/arch/x86/pci/mrst.c > index 6eb18c4..cd0a373 100644 > --- a/arch/x86/pci/mrst.c > +++ b/arch/x86/pci/mrst.c > @@ -251,8 +251,8 @@ static void pci_d3delay_fixup(struct pci_dev *dev) > { > /* PCI fixups are effectively decided compile time. If we have a dual > SoC/non-SoC kernel we don't want to mangle d3 on non SoC devices */ > - if (!pci_soc_mode) > - return; > + if (!pci_soc_mode) > + return; > /* true pci devices in lincroft should allow type 1 access, the rest > * are langwell fake pci devices. > */ If you do whitespace cleanups then please also fix all the other problems in that file, right now mrst.c has more than just one: total: 3 errors, 7 warnings, 3 checks, 303 lines checked plus the area you patched has some wierd comment formatting as well. For multi-line comments we use: /* * Comment ..... * ...... goes here. */ as specified in Documentation/CodingStyle. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/