Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932810Ab3GLLNa (ORCPT ); Fri, 12 Jul 2013 07:13:30 -0400 Received: from service87.mimecast.com ([91.220.42.44]:35691 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932637Ab3GLLN3 convert rfc822-to-8bit (ORCPT ); Fri, 12 Jul 2013 07:13:29 -0400 Date: Fri, 12 Jul 2013 12:13:22 +0100 From: Javi Merino To: Stephen Boyd Cc: "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-kernel@vger.kernel.org" , Nicolas Pitre Subject: Re: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system Message-ID: <20130712111322.GC3213@e102654-lin.cambridge.arm.com> References: <1373067573-29946-1-git-send-email-sboyd@codeaurora.org> MIME-Version: 1.0 In-Reply-To: <1373067573-29946-1-git-send-email-sboyd@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginalArrivalTime: 12 Jul 2013 11:13:23.0709 (UTC) FILETIME=[D2F8BAD0:01CE7EF0] X-MC-Unique: 113071212132700201 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1310 Lines: 30 On Sat, Jul 06, 2013 at 12:39:33AM +0100, Stephen Boyd wrote: > In a uniprocessor implementation the interrupt processor targets > registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately > gic_get_cpumask() will print a critical message saying > > GIC CPU mask not found - kernel will fail to boot. > > if these registers all read as zero, but there won't actually be > a problem on uniprocessor systems and the kernel will boot just > fine. Skip this check if we're running a UP kernel or if we > detect that the hardware only supports a single processor. > > Cc: Nicolas Pitre > Cc: Russell King > Signed-off-by: Stephen Boyd > --- > > Maybe we should just drop the check entirely? It looks like it may > just be debug code that won't ever trigger in practice, even on the > 11MPCore that caused this code to be introduced. I agree, we should drop the check. It's annoying in uniprocessors and unlikely to be found in the real world unless your gic entry in the dt is wrong. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/