Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933096Ab3GLMK1 (ORCPT ); Fri, 12 Jul 2013 08:10:27 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:51334 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932851Ab3GLMKZ (ORCPT ); Fri, 12 Jul 2013 08:10:25 -0400 Date: Fri, 12 Jul 2013 05:10:23 -0700 From: Stephen Boyd To: Javi Merino Cc: "linux-arm-kernel@lists.infradead.org" , Russell King , "linux-kernel@vger.kernel.org" , Nicolas Pitre Subject: Re: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system Message-ID: <20130712121023.GB27430@codeaurora.org> References: <1373067573-29946-1-git-send-email-sboyd@codeaurora.org> <20130712111322.GC3213@e102654-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130712111322.GC3213@e102654-lin.cambridge.arm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2826 Lines: 80 On 07/12, Javi Merino wrote: > On Sat, Jul 06, 2013 at 12:39:33AM +0100, Stephen Boyd wrote: > > In a uniprocessor implementation the interrupt processor targets > > registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately > > gic_get_cpumask() will print a critical message saying > > > > GIC CPU mask not found - kernel will fail to boot. > > > > if these registers all read as zero, but there won't actually be > > a problem on uniprocessor systems and the kernel will boot just > > fine. Skip this check if we're running a UP kernel or if we > > detect that the hardware only supports a single processor. > > > > Cc: Nicolas Pitre > > Cc: Russell King > > Signed-off-by: Stephen Boyd > > --- > > > > Maybe we should just drop the check entirely? It looks like it may > > just be debug code that won't ever trigger in practice, even on the > > 11MPCore that caused this code to be introduced. > > I agree, we should drop the check. It's annoying in uniprocessors and > unlikely to be found in the real world unless your gic entry in the dt > is wrong. > Ok. How about this? ----8<----- Subject: [PATCH v2] irqchip: gic: Don't complain in gic_get_cpumask() In a uniprocessor implementation the interrupt processor targets registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately gic_get_cpumask() will print a critical message saying GIC CPU mask not found - kernel will fail to boot. if these registers all read as zero, but there won't actually be a problem on uniprocessor systems and the kernel will boot just fine. Remove this check because if you're on a multiprocessor system it's unlikely to be printed unless your DT is wrong or your hardware is broken. Cc: Nicolas Pitre Cc: Russell King Cc: Javi Merino Signed-off-by: Stephen Boyd --- drivers/irqchip/irq-gic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 19ceaa60..4fbcea9 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -368,9 +368,6 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic) break; } - if (!mask) - pr_crit("GIC CPU mask not found - kernel will fail to boot.\n"); - return mask; } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/