Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964812Ab3GLM7n (ORCPT ); Fri, 12 Jul 2013 08:59:43 -0400 Received: from mga09.intel.com ([134.134.136.24]:22646 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933178Ab3GLM7l (ORCPT ); Fri, 12 Jul 2013 08:59:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,652,1367996400"; d="scan'208";a="369134560" Date: Fri, 12 Jul 2013 16:05:08 +0300 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , Bjorn Helgaas , LKML , Linux PCI , Yinghai Lu , Jiang Liu Subject: Re: [RFC][PATCH 23/30] ACPI / hotplug / PCI: Do not exectute _PS0 and _PS3 directly Message-ID: <20130712130508.GK4898@intel.com> References: <26431283.HJCKsss0rt@vostro.rjw.lan> <3718119.FLASu5DBx8@vostro.rjw.lan> <1757750.sf0hy8txF5@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1757750.sf0hy8txF5@vostro.rjw.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1333 Lines: 38 On Fri, Jul 12, 2013 at 02:01:30AM +0200, Rafael J. Wysocki wrote: > Index: linux-pm/drivers/pci/hotplug/acpiphp.h > =================================================================== > --- linux-pm.orig/drivers/pci/hotplug/acpiphp.h > +++ linux-pm/drivers/pci/hotplug/acpiphp.h > @@ -160,7 +160,6 @@ struct acpiphp_attention_info > > /* slot flags */ > > -#define SLOT_POWEREDON (0x00000001) > #define SLOT_ENABLED (0x00000002) > #define SLOT_MULTIFUNCTION (0x00000004) > > @@ -168,11 +167,7 @@ struct acpiphp_attention_info > > #define FUNC_HAS_STA (0x00000001) > #define FUNC_HAS_EJ0 (0x00000002) > -#define FUNC_HAS_PS0 (0x00000010) > -#define FUNC_HAS_PS1 (0x00000020) > -#define FUNC_HAS_PS2 (0x00000040) > -#define FUNC_HAS_PS3 (0x00000080) > -#define FUNC_HAS_DCK (0x00000100) > +#define FUNC_HAS_DCK (0x00000003) These are flags not enum so the above wants to be #define FUNC_HAS_DCK (0x00000004) otherwise we accidentally match checks like: /* install notify handler */ if (!(newfunc->flags & FUNC_HAS_DCK)) { ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/