Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965003Ab3GLNvj (ORCPT ); Fri, 12 Jul 2013 09:51:39 -0400 Received: from mail-we0-f170.google.com ([74.125.82.170]:63136 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964861Ab3GLNvi (ORCPT ); Fri, 12 Jul 2013 09:51:38 -0400 Date: Fri, 12 Jul 2013 14:51:33 +0100 From: Lee Jones To: Peter Ujfalusi Cc: Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] MFD: twl6040: Cleanup in early error handling in probe function Message-ID: <20130712135133.GN25601@gmail.com> References: <1373628724-11397-1-git-send-email-peter.ujfalusi@ti.com> <1373628724-11397-3-git-send-email-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1373628724-11397-3-git-send-email-peter.ujfalusi@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 21 On Fri, 12 Jul 2013, Peter Ujfalusi wrote: > The err: label is not needed we can just return instead of the jump there. > > Signed-off-by: Peter Ujfalusi > --- > drivers/mfd/twl6040.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) Nice little clean-up. Applied, thanks. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/