Date: Fri, 12 Jul 2013 16:55:15 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
        Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
        Paul Mackerras <paulus@samba.org>,
        Stephane Eranian <eranian@google.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH V5 09/12] perf: make events stream always parsable
Message-ID: <20130712145515.GI17211@twins.programming.kicks-ass.net>
References: <1373548341-24119-1-git-send-email-adrian.hunter@intel.com>
 <1373548341-24119-10-git-send-email-adrian.hunter@intel.com>
 <20130712095600.GT25631@dyad.programming.kicks-ass.net>
 <51DFFCE1.1070203@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51DFFCE1.1070203@intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 743
Lines: 15

On Fri, Jul 12, 2013 at 03:56:01PM +0300, Adrian Hunter wrote:
> > There's events where this isn't a possible location; take PERF_RECORD_MMAP for
> > instance; the tail is the complete filename.
> 
> PERF_RECORD_MMAP falls in the category I have called non-sample events.
> Those events are appended with an ID sample.  perf tools parses the ID
> sample backwards from header.size.  So the ID is at the last position
> relative to header.size

But why? Why make it different per PERF_RECORD type? 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/