Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965411Ab3GLUcs (ORCPT ); Fri, 12 Jul 2013 16:32:48 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:40311 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965283Ab3GLUcq (ORCPT ); Fri, 12 Jul 2013 16:32:46 -0400 From: "Rafael J. Wysocki" To: Toshi Kani Cc: Yasuaki Ishimatsu , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ACPI / memhotplug: Fix a stale pointer in error path Date: Fri, 12 Jul 2013 22:42:33 +0200 Message-ID: <3723604.ey6eovWnzB@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <1373640689.24916.15.camel@misato.fc.hp.com> References: <1373474833-14047-1-git-send-email-toshi.kani@hp.com> <51DF4CB6.4060903@jp.fujitsu.com> <1373640689.24916.15.camel@misato.fc.hp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 53 On Friday, July 12, 2013 08:51:29 AM Toshi Kani wrote: > On Fri, 2013-07-12 at 09:24 +0900, Yasuaki Ishimatsu wrote: > > (2013/07/11 1:47), Toshi Kani wrote: > > > device->driver_data needs to be cleared when releasing its data, > > > mem_device, in an error path of acpi_memory_device_add(). > > > > > > Signed-off-by: Toshi Kani > > > --- > > > > Reviewed-by: Yasuaki Ishimatsu > > Thanks Yasuaki! Queued up as a fix for 3.11. Do we need that in -stable as well? Rafael > > > > > drivers/acpi/acpi_memhotplug.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > > > index c711d11..999adb5 100644 > > > --- a/drivers/acpi/acpi_memhotplug.c > > > +++ b/drivers/acpi/acpi_memhotplug.c > > > @@ -323,6 +323,7 @@ static int acpi_memory_device_add(struct acpi_device *device, > > > /* Get the range from the _CRS */ > > > result = acpi_memory_get_device_resources(mem_device); > > > if (result) { > > > + device->driver_data = NULL; > > > kfree(mem_device); > > > return result; > > > } > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > > > > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/