Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758037Ab3GMBQh (ORCPT ); Fri, 12 Jul 2013 21:16:37 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:37782 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757984Ab3GMBQg (ORCPT ); Fri, 12 Jul 2013 21:16:36 -0400 X-Sasl-enc: EEwtSLkIsZMh927WIPn4lQ02V8Tc2xoPoYuGkxVHJgyJ 1373678194 Date: Fri, 12 Jul 2013 18:17:31 -0700 From: Greg KH To: Darren Hart Cc: Linux Kernel Mailing List , "David S. Miller" , "H. Peter Anvin" , Peter Waskiewicz , Andy Shevchenko , netdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support Message-ID: <20130713011731.GA17939@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2805 Lines: 53 On Fri, Jul 12, 2013 at 05:58:07PM -0700, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > and add a pci_device_id.driver_data structure and functions to handle > platform setup. > > The AR803x does not implement the RGMII 2ns TX clock delay in the trace > routing nor via strapping. Add a detection method for the board and the > PHY and enable the TX clock delay via the registers. > > This PHY will hibernate without link for 10 seconds. Ensure the PHY is > awake for probe and then disable hibernation. A future improvement would > be to convert pch_gbe to using PHYLIB and making sure we can wake the > PHY at the necessary times rather than permanently disabling it. > > Signed-off-by: Darren Hart > Cc: "David S. Miller" > Cc: "H. Peter Anvin" > Cc: Peter Waskiewicz > Cc: Andy Shevchenko > Cc: netdev@vger.kernel.org > Cc: # 3.8.x: 5829e9b mfd: lpc_sch: Accomodate partial > Cc: # 3.8.x: 3cbf182 gpio-sch: Allow for more than 8 > Cc: # 3.8.x: 91bbe92: PCI: Add CircuitCo vendor ID > Cc: # 3.8.x: bd79680: pch_gbe: remove inline keyword > Cc: # 3.8.x: 453ca93: pch_gbe: convert pr_* to > Cc: # 3.8.x: 29cc436: pch_gbe: use managed functions > Cc: # 3.8.x > Cc: # 3.10.x: 91bbe92: PCI: Add CircuitCo vendor ID > Cc: # 3.10.x: bd79680: pch_gbe: remove inline keyword > Cc: # 3.10.x: 453ca93: pch_gbe: convert pr_* to > Cc: # 3.10.x: 29cc436: pch_gbe: use managed functions > Cc: # 3.10.x > Signed-off-by: Darren Hart > --- > drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 15 ++++ > .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 48 +++++++++++ > .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c | 98 ++++++++++++++++++++++ > .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h | 2 + > 4 files changed, 163 insertions(+) This is _far_ more than just a simple "add a new device id" for a stable kernel update. Please go read Documentation/stable_kernel_rules.txt again for why there's no way I can take this type of thing. You know better than this. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/