MIME-Version: 1.0
In-Reply-To: <20130712074558.GP18798@sgi.com>
References: <1373594635-131067-1-git-send-email-holt@sgi.com>
	<1373594635-131067-3-git-send-email-holt@sgi.com>
	<20130712074558.GP18798@sgi.com>
Date: Fri, 12 Jul 2013 20:08:56 -0700
Message-ID: <CAE9FiQVYApvncM0gKZYoJ9LE0636rhCD70qGJe0ksxeXQ68jWw@mail.gmail.com>
Subject: Re: [RFC 2/4] Have __free_pages_memory() free in larger chunks.
From: Yinghai Lu <yinghai@kernel.org>
To: Robin Holt <holt@sgi.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
        Nate Zimmer <nzimmer@sgi.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>, Rob Landley <rob@landley.net>,
        Mike Travis <travis@sgi.com>,
        Daniel J Blueman <daniel@numascale-asia.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Greg KH <gregkh@linuxfoundation.org>, Mel Gorman <mgorman@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 813
Lines: 27

On Fri, Jul 12, 2013 at 12:45 AM, Robin Holt <holt@sgi.com> wrote:

> At the very least, I think we could change to:
> static void __init __free_pages_memory(unsigned long start, unsigned long end)
> {
>         int order;
>
>         while (start < end) {
>                 order = ffs(start);
>
>                 while (start + (1UL << order) > end)
>                         order--;
>
>                 __free_pages_bootmem(start, order);
>
>                 start += (1UL << order);
>         }
> }

should work, but need to make sure order < MAX_ORDER.

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/