Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540Ab3GMFxG (ORCPT ); Sat, 13 Jul 2013 01:53:06 -0400 Received: from mga14.intel.com ([143.182.124.37]:2277 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076Ab3GMFxE (ORCPT ); Sat, 13 Jul 2013 01:53:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,657,1367996400"; d="scan'208";a="330745536" Message-ID: <1373694766.3475.98.camel@envy.home> Subject: Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support From: Darren Hart To: Joe Perches Cc: Linux Kernel Mailing List , "David S. Miller" , "H. Peter Anvin" , Peter Waskiewicz , Andy Shevchenko , netdev@vger.kernel.org, stable@vger.kernel.org Date: Fri, 12 Jul 2013 22:52:46 -0700 In-Reply-To: <1373677813.2614.23.camel@joe-AO722> References: <1373677087-7747-1-git-send-email-dvhart@linux.intel.com> <1373677813.2614.23.camel@joe-AO722> Organization: Intel Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.3 (3.8.3-2.fc19) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2503 Lines: 83 On Fri, 2013-07-12 at 18:10 -0700, Joe Perches wrote: > On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > > and add a pci_device_id.driver_data structure and functions to handle > > platform setup. > > trivial comments only: > > Please use scripts/checkpatch.pl Always good advice. I did actually do that. Some of the reports conflict with existing formatting throughout the file. I opted for consistency. The others.... sigh, I did a last minute cleanup and somehow introduced the whitespace errors. I do know better and should have waited until tonight instead of sending them out when I was rushed. Apologies. Fixed in V3 and awaiting additional feedback. > > [] > > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c[] > [] > > +static int pch_gbe_minnow_platform_init(struct pci_dev *pdev) > [] > > + if (ret){ > > Missing space before brace Fixed. > > > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c > [] > > +int pch_gbe_phy_tx_clk_delay(struct pch_gbe_hw *hw) > [] > > + case PHY_AR803X_ID: > > + netdev_dbg(adapter->netdev, > > + "Configuring AR803X PHY for 2ns TX clock delay\n"); > [] > > + netdev_err(adapter->netdev, > > + "Unknown PHY (%x), could not set TX clock delay.\n", > > + hw->phy.id); > [] > > + netdev_err(adapter->netdev, > > + "Could not configure tx clock delay for PHY.\n"); > [] > > +int pch_gbe_phy_disable_hibernate(struct pch_gbe_hw *hw) > [] > > + case PHY_AR803X_ID: > > + netdev_dbg(adapter->netdev, > > + "Disabling hibernation for AR803X PHY\n"); > > It'd be nice if no period before newline were used > everywhere. Indeed, fixed. Thank you for the review. > > > + netdev_err(adapter->netdev, > > + "Unknown PHY (%x), could not disable hibernation\n", > > + hw->phy.id); > [] > > + netdev_err(adapter->netdev, > > + "Could not disable PHY hibernation.\n"); > > -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/