Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751847Ab3GMGW3 (ORCPT ); Sat, 13 Jul 2013 02:22:29 -0400 Received: from mail-pb0-f53.google.com ([209.85.160.53]:39351 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751306Ab3GMGW1 (ORCPT ); Sat, 13 Jul 2013 02:22:27 -0400 Date: Fri, 12 Jul 2013 23:22:23 -0700 From: Greg Kroah-Hartman To: Willy Tarreau Cc: Linus Torvalds , Guenter Roeck , Dave Jones , Linux Kernel Mailing List , Andrew Morton , stable Subject: Re: [ 00/19] 3.10.1-stable review Message-ID: <20130713062223.GA15155@kroah.com> References: <20130711214830.611455274@linuxfoundation.org> <20130711222935.GA11340@redhat.com> <20130711224455.GA17222@kroah.com> <20130712141530.GA3629@roeck-us.net> <20130712173150.GA5534@roeck-us.net> <20130712195051.GB32054@1wt.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130712195051.GB32054@1wt.eu> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2453 Lines: 49 On Fri, Jul 12, 2013 at 09:50:51PM +0200, Willy Tarreau wrote: > On Fri, Jul 12, 2013 at 10:50:08AM -0700, Linus Torvalds wrote: > > So I'm not going to argue that your particular patches were the > > problem here. I'm more arguing against your arguments than against the > > patches themselves. I'm not looking for some hard black-and-white > > rules that say "this is exactly how things have to work", because I > > don't think such rules can exist. But I _do_ want people to see the > > stable rules as fairly strict. > > I think that maintainers are balanced between the wish to satisfy their > users and the risk of getting shouted at. Users expect stable versions > to be bug-free. Most people I talk with have a different understanding > of the development model than the one you present to contributors. They > think that the .0 release is a draft and that all bugs will be fixed in > -stable. I even know one person who uses -rc1 in production, claiming > that these ones are stable. So end users don't necessarily understand > the development model and ask what something they think is due : no > known bugs. > > On the other hand, we've seen many regressions introduced as fixes > into -stable that had to be reverted afterwards, or sometimes > completed with a missing patch. > > I think that maintainers use the Cc:stable as a status for commits > meaning "this is a bug fix". It's true that when you're digging into > the commits to try to qualify fixes from features, it's really hard, > and the new Cc:stable tag helps a lot. > > So probably we should incite patch contributors to add a specific > tag such as "Fixes: 3.5 and later", so that non-important patches > do not need the Cc:stable anymore, but users who experience an issue > can easily spot them and ask for their inclusion. Huh? What's wrong with the existing way people mark stable patches to go back to much older kernel versions? Is that not working well enough for you? And if something "fixes" an issue, then I want it in stable, just like Linus wants that in his tree. Don't add another tag that requires users to dig for fixes that we are just too lazy to be including for all users, that way is crazy. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/