Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932135Ab3GOOib (ORCPT ); Mon, 15 Jul 2013 10:38:31 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:47762 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756020Ab3GOOi3 (ORCPT ); Mon, 15 Jul 2013 10:38:29 -0400 MIME-Version: 1.0 In-Reply-To: <201307151624.57438.marex@denx.de> References: <1373898160-8460-1-git-send-email-otavio@ossystems.com.br> <1373898160-8460-2-git-send-email-otavio@ossystems.com.br> <201307151624.57438.marex@denx.de> Date: Mon, 15 Jul 2013 11:38:28 -0300 X-Google-Sender-Auth: BB-ExGZI6FXueE73oq7cV97zyjY Message-ID: Subject: Re: [PATCH 2/5] ARM: mxs-lradc: Simplify mxs_lradc_trigger_init error handle From: Otavio Salvador To: Marek Vasut Cc: Jonathan Cameron , Kernel development list , Jonathan Cameron , Greg Kroah-Hartman , Bill Pemberton , Lars-Peter Clausen , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1484 Lines: 41 On Mon, Jul 15, 2013 at 11:24 AM, Marek Vasut wrote: > Dear Otavio Salvador, > >> As we have a 'ret' variable with the iio_trigger_register return, this >> can be used as result. >> >> Signed-off-by: Otavio Salvador >> --- >> drivers/staging/iio/adc/mxs-lradc.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/iio/adc/mxs-lradc.c >> b/drivers/staging/iio/adc/mxs-lradc.c index d92c97a..6d41846 100644 >> --- a/drivers/staging/iio/adc/mxs-lradc.c >> +++ b/drivers/staging/iio/adc/mxs-lradc.c >> @@ -671,14 +671,12 @@ static int mxs_lradc_trigger_init(struct iio_dev >> *iio) trig->ops = &mxs_lradc_trigger_ops; >> >> ret = iio_trigger_register(trig); >> - if (ret) { >> + if (ret) >> iio_trigger_free(trig); >> - return ret; >> - } >> >> iio->trig = trig; > > > You are still setting iio->trig , you dont want to do that in case of failure In this case it'd end being NULL I think, wouldn't it? -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://projetos.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/