Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932992Ab3GOP0M (ORCPT ); Mon, 15 Jul 2013 11:26:12 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:26633 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932670Ab3GOP0K (ORCPT ); Mon, 15 Jul 2013 11:26:10 -0400 Date: Mon, 15 Jul 2013 11:25:32 -0400 From: Konrad Rzeszutek Wilk To: Julien Grall Cc: stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, patches@linaro.org, linux-kernel@vger.kernel.org, xen-devel@lists.xen.org, linux-arm-kernel@lists.infradead.org Subject: Re: [Xen-devel] [PATCH] xen/arm: disable cpuidle when linux is running as dom0 Message-ID: <20130715152532.GC5774@phenom.dumpdata.com> References: <1373898101-15633-1-git-send-email-julien.grall@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1373898101-15633-1-git-send-email-julien.grall@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1618 Lines: 54 On Mon, Jul 15, 2013 at 03:21:41PM +0100, Julien Grall wrote: > When linux is running as dom0, Xen doesn't show the physical cpu but a > virtual CPU. > On some ARM SOC (for instance the exynos 5250), linux registers callbacks > for cpuidle. When these callbacks are called, they will modify > directly the physical cpu not the virtual one. It can impact the whole board > instead of dom0. Should you also call disable_cpufreq() ? > > Signed-off-by: Julien Grall > --- > arch/arm/xen/enlighten.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > index 49839d8..a98999f 100644 > --- a/arch/arm/xen/enlighten.c > +++ b/arch/arm/xen/enlighten.c > @@ -24,6 +24,8 @@ > #include > #include > #include > +#include > +#include > > #include > > @@ -292,6 +294,11 @@ static int __init xen_pm_init(void) > { > pm_power_off = xen_power_off; > arm_pm_restart = xen_restart; > + /* > + * Making sure board specific code will not set up ops for > + * cpu idle. > + */ > + disable_cpuidle(); > > return 0; > } > -- > 1.7.10.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/