Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758000Ab3GOVhw (ORCPT ); Mon, 15 Jul 2013 17:37:52 -0400 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:36943 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754002Ab3GOVhv (ORCPT ); Mon, 15 Jul 2013 17:37:51 -0400 Date: Mon, 15 Jul 2013 22:37:27 +0100 From: Russell King - ARM Linux To: Mark Brown Cc: Jean-Francois Moine , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood Subject: Re: [PATCH] ASoC: kirkwood-i2s: fix a compilation warning Message-ID: <20130715213727.GW24642@n2100.arm.linux.org.uk> References: <20130715103644.04e57749@armhf> <20130715153101.GK11538@sirena.org.uk> <20130715203756.68abbf10@armhf> <20130715200851.GD11538@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130715200851.GD11538@sirena.org.uk> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 13 On Mon, Jul 15, 2013 at 09:08:51PM +0100, Mark Brown wrote: > There's no obvious code that handles anything differently with extclk. > Indeed if you think about it for a minute you'll realise there's no way > the driver will ever use an extclk - set_rate() is badly implemented, > look at how other drivers select between clocks. I suggest you go back and re-read the driver because it most certainly does use extclk. What makes you think it won't? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/