Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751152Ab3GPFQ1 (ORCPT ); Tue, 16 Jul 2013 01:16:27 -0400 Received: from mail-oa0-f47.google.com ([209.85.219.47]:39964 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750741Ab3GPFQ0 (ORCPT ); Tue, 16 Jul 2013 01:16:26 -0400 MIME-Version: 1.0 In-Reply-To: References: <1373361330-3946-1-git-send-email-realmz6@kernel.org> Date: Tue, 16 Jul 2013 13:16:25 +0800 Message-ID: Subject: Re: [uclinux-dist-devel] [GIT PULL] Blackfin updates for 3.11 From: Steven Miao To: Linus Torvalds Cc: Geert Uytterhoeven , Steven Miao , Stephen Rothwell , "uclinux-dist-devel@blackfin.uclinux.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 24 On Tue, Jul 16, 2013 at 1:49 AM, Linus Torvalds wrote: > On Mon, Jul 15, 2013 at 10:28 AM, Geert Uytterhoeven > wrote: >> >> but the first one is non-trivial: using xchg() on atomic_t is a bit gross... > > It's also broken. There's no guarantee that an "atomic_t" is just a > value. Now, the old sparc32 stuff (which hid lock bits in atomic_t) > may be gone, but it's still the case that atomic_t may not actually > work with xchg. > > (In *practice* it works on normal architectures, so I'm not saying > that we don't have it, but it's a bug if we do). > > There are "atomic_xchg()" and "atomic_xchg64()" functions that are supported. I'll send a patch to fix it. > > Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/