Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755053Ab3GPSrH (ORCPT ); Tue, 16 Jul 2013 14:47:07 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:58148 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754956Ab3GPSrE (ORCPT ); Tue, 16 Jul 2013 14:47:04 -0400 Date: Tue, 16 Jul 2013 14:47:02 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: boris brezillon cc: Nicolas Ferre , Ludovic Desroches , Jean-Christophe Plagniol-Villard , Greg Kroah-Hartman , , , Subject: Re: [PATCH v3 6/7] USB: ohci-at91: add usb_clk for transition to common clk framework In-Reply-To: <51E57DFC.5030302@overkiz.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1419 Lines: 34 On Tue, 16 Jul 2013, boris brezillon wrote: > >> + uclk = clk_get(&pdev->dev, "usb_clk"); > >> + if (IS_ERR(uclk)) { > >> + uclk = NULL; > >> + dev_warn(&pdev->dev, "failed to get usb_clk\n"); > >> + } > > Is this really what you want for backward compatibility? > Here are some proposition to remove the warning message: > > 1) replace it with a dev_info and change the message: > dev_info(&pdev->dev, "failed to get usb_clk (most likely using old > at91 clk implementation)\n"); > 2) drop the log and silently ignore the missing clk (I'm not a big fan > of this solution > as it may lead to some errors if we're using new clk implem and the > clock is really missing) > 3) rework the current clk_set_rate function to accept clk_set_rate on > usb clk and add clk_lookup entries > for the usb clk (I'm not a big fan of this solution neither as this > modifications will only be used for a short time > until the transition to common clk framework is completed). Another possibility is to combine this change with the clock implementation update, and do them in a single patch. Then backward compatibility would not be an issue. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/