Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933717Ab3GPWts (ORCPT ); Tue, 16 Jul 2013 18:49:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37921 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933246Ab3GPWtr (ORCPT ); Tue, 16 Jul 2013 18:49:47 -0400 Date: Tue, 16 Jul 2013 15:49:45 -0700 From: Andrew Morton To: Davidlohr Bueso Cc: riel@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 03/11] ipc: drop ipcctl_pre_down Message-Id: <20130716154945.91aebe21a18ef3c4580c7a91@linux-foundation.org> In-Reply-To: <1371604716-3439-4-git-send-email-davidlohr.bueso@hp.com> References: <1371604716-3439-1-git-send-email-davidlohr.bueso@hp.com> <1371604716-3439-4-git-send-email-davidlohr.bueso@hp.com> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1820 Lines: 52 On Tue, 18 Jun 2013 18:18:28 -0700 Davidlohr Bueso wrote: > Now that sem, msgque and shm, through *_down(), all use the lockless > variant of ipcctl_pre_down(), go ahead and delete it. Fixlets: From: Andrew Morton Subject: ipc-drop-ipcctl_pre_down-fix fix function name in kerneldoc, cleanups Cc: Davidlohr Bueso Cc: Manfred Spraul Cc: Rik van Riel Cc: Sedat Dilek Signed-off-by: Andrew Morton --- ipc/util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN ipc/util.c~ipc-drop-ipcctl_pre_down-fix ipc/util.c --- a/ipc/util.c~ipc-drop-ipcctl_pre_down-fix +++ a/ipc/util.c @@ -733,7 +733,7 @@ int ipc_update_perm(struct ipc64_perm *i } /** - * ipcctl_pre_down - retrieve an ipc and check permissions for some IPC_XXX cmd + * ipcctl_pre_down_nolock - retrieve an ipc and check permissions for some IPC_XXX cmd * @ns: the ipc namespace * @ids: the table of ids where to look for the ipc * @id: the id of the ipc to retrieve @@ -751,8 +751,8 @@ int ipc_update_perm(struct ipc64_perm *i * Call holding the both the rw_mutex and the rcu read lock. */ struct kern_ipc_perm *ipcctl_pre_down_nolock(struct ipc_namespace *ns, - struct ipc_ids *ids, int id, int cmd, - struct ipc64_perm *perm, int extra_perm) + struct ipc_ids *ids, int id, int cmd, + struct ipc64_perm *perm, int extra_perm) { kuid_t euid; int err = -EPERM; _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/