Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934038Ab3GQAIN (ORCPT ); Tue, 16 Jul 2013 20:08:13 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:48042 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933956Ab3GQAIL (ORCPT ); Tue, 16 Jul 2013 20:08:11 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 16 Jul 2013 20:08:09 -0400 Message-ID: Subject: Re: [PATCH] BGRT: Don't ioremap if image address is in System RAM (was: Re: BGRT Pointer in System RAM) From: Parag Warudkar To: Andy Lutomirski Cc: linux-acpi@vger.kernel.org, Linux Kernel Mailing List , Josh Triplett Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 30 On Tue, Jul 16, 2013 at 7:32 PM, Andy Lutomirski wrote: > Fair enough. I leave it to the experts to comment on whether there > should be some explicit check of whether this is > EFI_BOOT_SERVICES_DATA. > I am reading the code again and something doesn't sound right. The original code calls efi_lookup_mapped_address. It doesn't find the image address there - which is strange given that on my system the address lies in mem type 4 as printed during boot. Hmm. But then phys_to_virt on the same address succeeds and we can read the image off of that. I might need to do some debugging of efi_lookup_mapped_address to see why it isn't finding it there. If it did find it there, none of the ioremap issues would arise. > FWIW, if my board does indeed have a DWORD-swapped address, it's in > plain old RAM (type=7). Yeah, for the status invalid case I think we would be better off just ignoring it. Too much heuristic trickery required and it might not be worth it after all that if the firmware didn't bother putting a proper image in there. Parag -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/