Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905Ab3GQF2n (ORCPT ); Wed, 17 Jul 2013 01:28:43 -0400 Received: from mail-ob0-f179.google.com ([209.85.214.179]:65449 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751151Ab3GQF2k (ORCPT ); Wed, 17 Jul 2013 01:28:40 -0400 MIME-Version: 1.0 In-Reply-To: <20130716140632.70fb2838@amdc308.digital.local> References: <1370502472-7249-1-git-send-email-l.majewski@samsung.com> <1372927830-2949-1-git-send-email-l.majewski@samsung.com> <1372927830-2949-3-git-send-email-l.majewski@samsung.com> <20130716140632.70fb2838@amdc308.digital.local> Date: Wed, 17 Jul 2013 10:58:40 +0530 Message-ID: Subject: Re: [PATCH v5 2/7] cpufreq: Add boost frequency support in core From: Viresh Kumar To: Lukasz Majewski Cc: "Rafael J. Wysocki" , Zhang Rui , Eduardo Valentin , "cpufreq@vger.kernel.org" , Linux PM list , Jonghwa Lee , l.majewski@majess.pl, linux-kernel , Andre Przywara , Daniel Lezcano , Kukjin Kim , Myungjoo Ham Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1092 Lines: 27 On 16 July 2013 17:36, Lukasz Majewski wrote: > On Tue, 16 Jul 2013 15:11:54 +0530 Viresh Kumar viresh.kumar@linaro.org > wrote, >> On 4 July 2013 14:20, Lukasz Majewski wrote: >> > +void cpufreq_set_boost_enabled(int state) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [*] > >> >> Maybe cpufreq_block_boost? As suggested by Rafael. > > What do you mean by cpufreq_block_boost()? This name would reverse the > logic. > > Function [*] is used to change boost_enabled static flag (defined at > cpufreq.c file) state according to acpi-cpufreq.c boost support status. I misread it again :( So, what about adding another field in struct cpufreq_driver: boost_enabled? And get rid of the global boost_enabled we have used? Similar to how boost_supported is used, then we don't need this routine. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/