Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752371Ab3GQHBB (ORCPT ); Wed, 17 Jul 2013 03:01:01 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:50585 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752264Ab3GQHA7 (ORCPT ); Wed, 17 Jul 2013 03:00:59 -0400 X-AuditID: cbfee61b-b7efe6d000007b11-80-51e641239430 Date: Wed, 17 Jul 2013 09:00:44 +0200 From: Lukasz Majewski To: Viresh Kumar Cc: "Rafael J. Wysocki" , Zhang Rui , Eduardo Valentin , "cpufreq@vger.kernel.org" , Linux PM list , Jonghwa Lee , l.majewski@majess.pl, linux-kernel , Andre Przywara , Daniel Lezcano , Kukjin Kim , Myungjoo Ham Subject: Re: [PATCH v5 2/7] cpufreq: Add boost frequency support in core Message-id: <20130717090044.4392d86a@amdc308.digital.local> In-reply-to: References: <1370502472-7249-1-git-send-email-l.majewski@samsung.com> <1372927830-2949-1-git-send-email-l.majewski@samsung.com> <1372927830-2949-3-git-send-email-l.majewski@samsung.com> <20130716140632.70fb2838@amdc308.digital.local> Organization: SPRC Poland X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42I5/e+xgK6y47NAg4UL5Sz+vF3OavG06Qe7 xbzPshZr9v9ksug8+4TZonfBVTaLN4+4LS7vmsNm8bn3CKPF7cYVbBb9C3uZLJ487GOz2PjV w4HXY/Gel0wed67tYfNYN+0ts0ffllWMHo8WtzB6HL+xncnj8ya5APYoLpuU1JzMstQifbsE royFfb3MBd84KlbdvMHWwNjN3sXIySEhYCIx6c5bZghbTOLCvfVsXYxcHEICixgllh//wg7h tDNJTFpzgw2kikVAVeL3v0dgNpuAnsTnu0+Zuhg5OEQEtCRe3kwFqWcW+MgscffgbRaQGmEB D4lFu++A1fAKWEt8nJsNEuYUCJbYOHsWM8T8v0wSE343gF3BLyAp0f7vB9RFdhLnPm0Au5RX QFDix+R7YDOZgXZt3tbECmHLS2xe85Z5AqPgLCRls5CUzUJStoCReRWjaGpBckFxUnqukV5x Ym5xaV66XnJ+7iZGcCQ9k97BuKrB4hCjAAejEg/vhLCngUKsiWXFlbmHGCU4mJVEeKs1ngUK 8aYkVlalFuXHF5XmpBYfYpTmYFES5z3Yah0oJJCeWJKanZpakFoEk2Xi4JRqYGz+Pf2KWvDD xxJF97bsZdstIWvXsuDt7qR1C0wmGU/iOR93lGHSVQnbQ0wlCff0rm+OvDFlz/yzT9cFbmH5 N83HdY98wOqX/2QNvRiWuHIWmh+ZsW/H26APPz6HyR7gy3FdyHi4Tj+NXzdR+UntqlXbHnBn G894sPCXqt+KST3XPmtecDjGr2WqxFKckWioxVxUnAgACYFlHKACAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 41 On Wed, 17 Jul 2013 10:58:40 +0530 Viresh Kumar viresh.kumar@linaro.org wrote, > On 16 July 2013 17:36, Lukasz Majewski wrote: > > On Tue, 16 Jul 2013 15:11:54 +0530 Viresh Kumar > > viresh.kumar@linaro.org wrote, > >> On 4 July 2013 14:20, Lukasz Majewski > >> wrote: > > >> > +void cpufreq_set_boost_enabled(int state) > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [*] > > > >> > >> Maybe cpufreq_block_boost? As suggested by Rafael. > > > > What do you mean by cpufreq_block_boost()? This name would reverse > > the logic. > > > > Function [*] is used to change boost_enabled static flag (defined at > > cpufreq.c file) state according to acpi-cpufreq.c boost support > > status. > > I misread it again :( > > So, what about adding another field in struct cpufreq_driver: > boost_enabled? And get rid of the global boost_enabled we have used? > Similar to how boost_supported is used, then we don't need this > routine. Ok, I will implement this. -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/