Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977Ab3GQIfm (ORCPT ); Wed, 17 Jul 2013 04:35:42 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:49712 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752029Ab3GQIfj (ORCPT ); Wed, 17 Jul 2013 04:35:39 -0400 MIME-Version: 1.0 In-Reply-To: <51E5AF35.2080301@gmail.com> References: <1373995163-9412-1-git-send-email-prabhakar.csengg@gmail.com> <51E5AF35.2080301@gmail.com> From: Prabhakar Lad Date: Wed, 17 Jul 2013 14:05:18 +0530 Message-ID: Subject: Re: [PATCH RFC v4] media: OF: add "sync-on-green-active" property To: Sylwester Nawrocki Cc: LMML , devicetree-discuss@lists.ozlabs.org, DLOS , LKML , linux-doc@vger.kernel.org, Sylwester Nawrocki Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 47 Hi Sylwester, Thanks for the review. On Wed, Jul 17, 2013 at 2:08 AM, Sylwester Nawrocki wrote: > Hi Prabhakar, > > [snip] >> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt >> b/Documentation/devicetree/bindings/media/video-interfaces.txt >> index e022d2d..5186c7e 100644 >> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt >> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt >> @@ -101,6 +101,9 @@ Optional endpoint properties >> array contains only one entry. >> - clock-noncontinuous: a boolean property to allow MIPI CSI-2 >> non-continuous >> clock mode. >> +- sync-on-green-active: polarity field when video synchronization is >> + Sync-On-Green. When set the driver determines whether it's a normal >> operation >> + or inverted operation. > > > Would you mind adding this entry after pclk-sample property description ? OK. > And how about describing it a bit more precisely and similarly to > VSYNC/HSYNC, > e.g. > > - sync-on-green-active: active state of Sync-on-green (SoG) signal, > 0/1 for LOW/HIGH respectively. > OK I'll paste the above one itself :-) -- Regards, Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/