Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754284Ab3GQL2T (ORCPT ); Wed, 17 Jul 2013 07:28:19 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:46767 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754225Ab3GQL2P (ORCPT ); Wed, 17 Jul 2013 07:28:15 -0400 From: "Rafael J. Wysocki" To: Igor Gnatenko Cc: Matthew Garrett , Aaron Lu , "linux-acpi@vger.kernel.org" , "daniel.vetter@ffwll.ch" , "seth.forshee@canonical.com" , "joeyli.kernel@gmail.com" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "lenb@kernel.org" Subject: Re: [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8 Date: Wed, 17 Jul 2013 13:38:10 +0200 Message-ID: <1953381.pqik7pbieu@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <1374038198.1884.1.camel@ThinkPad-X230.localdomain> References: <1370818899-8595-1-git-send-email-matthew.garrett@nebula.com> <2132122.eIEvjmIrrj@vostro.rjw.lan> <1374038198.1884.1.camel@ThinkPad-X230.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1778 Lines: 50 On Wednesday, July 17, 2013 09:16:38 AM Igor Gnatenko wrote: > On Wed, 2013-07-17 at 00:01 +0200, Rafael J. Wysocki wrote: > > On Tuesday, July 16, 2013 05:08:16 PM Matthew Garrett wrote: > > > On Tue, 2013-07-16 at 17:32 +0400, Igor Gnatenko wrote: > > > > Hmm. I found regression in user-space. In GNOME (maybe and other DEs) we no longer see switch status of backlight. > > > > > > Yeah, I can duplicate that. Rafael, we have to call > > > acpi_video_init_brightness() even if we're not going to initialise the > > > backlight - Thinkpads seem to use this as the trigger for enabling ACPI > > > notifications rather than handling it in firmware. This seems to do the > > > job: > > > > Igor, does this additional patch from Matthew help? > Yes. With this patch I have backlight switch indicator on my ThinkPad X230. OK, thanks for the confirmation. Can you please also check if applying the appended patch on top of the Matthew's one changes anything (ie. things still work)? Rafael --- drivers/acpi/video.c | 5 +++++ 1 file changed, 5 insertions(+) Index: linux-pm/drivers/acpi/video.c =================================================================== --- linux-pm.orig/drivers/acpi/video.c +++ linux-pm/drivers/acpi/video.c @@ -957,6 +957,11 @@ static void acpi_video_device_find_cap(s if (result) printk(KERN_ERR PREFIX "Create sysfs link\n"); + } else { + /* Remove the brightness object. */ + kfree(device->brightness->levels); + kfree(device->brightness); + device->brightness = NULL; } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/