Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757300Ab3GQUN7 (ORCPT ); Wed, 17 Jul 2013 16:13:59 -0400 Received: from mga02.intel.com ([134.134.136.20]:27560 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755990Ab3GQUN6 (ORCPT ); Wed, 17 Jul 2013 16:13:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,687,1367996400"; d="scan'208";a="372009056" Message-ID: <1374092034.7622.34.camel@envy.home> Subject: Re: [PATCH 3/3] pch_gbe: Add MinnowBoard support From: Darren Hart To: Linux Kernel Mailing List Cc: "David S. Miller" , "H. Peter Anvin" , Peter Waskiewicz , Andy Shevchenko , netdev@vger.kernel.org, stable@vger.kernel.org Date: Wed, 17 Jul 2013 13:13:54 -0700 In-Reply-To: References: <1373677087-7747-1-git-send-email-dvhart@linux.intel.com> Organization: Intel Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.3 (3.8.3-2.fc19) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1406 Lines: 32 On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > and add a pci_device_id.driver_data structure and functions to handle > platform setup. > > The AR803x does not implement the RGMII 2ns TX clock delay in the trace > routing nor via strapping. Add a detection method for the board and the > PHY and enable the TX clock delay via the registers. > > This PHY will hibernate without link for 10 seconds. Ensure the PHY is > awake for probe and then disable hibernation. A future improvement would > be to convert pch_gbe to using PHYLIB and making sure we can wake the > PHY at the necessary times rather than permanently disabling it. If anyone is following along to see where this goes, I have made this change independent of the minnowboard platform drivers and have resent it with all the collected feedback on to netdev following the netdev rules I was recently made aware of. Please follow along there if you are interested. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/