Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757342Ab3GQWIz (ORCPT ); Wed, 17 Jul 2013 18:08:55 -0400 Received: from mga09.intel.com ([134.134.136.24]:47682 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755192Ab3GQWIy (ORCPT ); Wed, 17 Jul 2013 18:08:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,687,1367996400"; d="scan'208";a="347360132" Subject: Re: [PATCH 3.11-rc1] crypto: Fix boot failure duetomoduledependency. From: Tim Chen To: Tetsuo Handa Cc: herbert@gondor.hengli.com.au, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org In-Reply-To: <201307180550.BDB51536.LHMQOOOVFJFSFt@I-love.SAKURA.ne.jp> References: <20130716115527.GA1034@gondor.apana.org.au> <201307162249.JEA41532.FFOLHVQJFtOOMS@I-love.SAKURA.ne.jp> <1373991828.22432.274.camel@schen9-DESK> <201307172052.EJE32506.OFMSFJQOFHtVOL@I-love.SAKURA.ne.jp> <1374079597.22432.314.camel@schen9-DESK> <201307180550.BDB51536.LHMQOOOVFJFSFt@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset="UTF-8" Date: Wed, 17 Jul 2013 15:08:56 -0700 Message-ID: <1374098936.22432.322.camel@schen9-DESK> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-1.fc14) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1559 Lines: 44 On Thu, 2013-07-18 at 05:50 +0900, Tetsuo Handa wrote: > Tim Chen wrote: > > > Therefore, I think possible solutions are either > > > > > > (a) built-in the dependent modules > > > > > > # grep crc /lib/modules/3.11.0-rc1+/modules.dep > > > kernel/drivers/scsi/sd_mod.ko: kernel/lib/crc-t10dif.ko > > > kernel/lib/crc-t10dif.ko: > > > > This approach will increase kernel size for those who are not using > > t10dif so some people may object. > > BTW, The PCLMULQDQ version does not need to be build in. > > sd_mod.ko must choose one from versions available as of loading sd_mod.ko. > Although it is not needed to built-in the PCLMULQDQ version for fixing the boot > failure, it is needed to built-in the PCLMULQDQ version for getting performance > improvement when PCLMULQDQ is supported. The code in crct10dif transform allocation: crct10dif_tfm = crypto_alloc_shash("crct10dif", 0, 0) will allocate a t10dif crypto transform with highest priority. So as long as the crct10dif.ko and crct10dif-pclmul.ko are loaded, the pclmulqdq t10dif will have a higher priority and get allocated and used. Thanks. Tim > > > Your approach is quite complicated. I think something simpler like the > > following will work: > > We cannot benefit from PCLMULQDQ. Is it acceptable for you? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/