Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758400Ab3GRG2N (ORCPT ); Thu, 18 Jul 2013 02:28:13 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:33907 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629Ab3GRG2L (ORCPT ); Thu, 18 Jul 2013 02:28:11 -0400 Message-ID: <51E78AC8.3020203@ti.com> Date: Thu, 18 Jul 2013 11:57:20 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Greg KH CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework References: <1372247257-30186-1-git-send-email-kishon@ti.com> <1372247257-30186-2-git-send-email-kishon@ti.com> <20130717062944.GA24968@kroah.com> <51E664CB.8050906@ti.com> <20130717172510.GB17093@kroah.com> <51E78525.9000802@ti.com> <20130718062447.GA19997@kroah.com> In-Reply-To: <20130718062447.GA19997@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1770 Lines: 41 On Thursday 18 July 2013 11:54 AM, Greg KH wrote: > On Thu, Jul 18, 2013 at 11:33:17AM +0530, Kishon Vijay Abraham I wrote: >>>> Wanted to group all the PHY drivers to be used by different subsystems >>>> (SATA/USB/PCIE/HDMI/VIDEO) into a single entity. There were some comments in my >>>> initial version [3] on using a bus_type instead of class but then it was >>>> decided to go with class itself. >>>> >>>> [3] -> http://lkml.indiana.edu/hypermail/linux/kernel/1302.2/01389.html >>> >>> Ok, but what does the class usage get you? >> >> hmm.. actually I use class only to iterate through the list of devices in *phy* >> class which could very well be implemented using list. Just that I wont have a >> /sys/class/phy/ entry to find the list of phys added in the system. I dont >> think I want to add any other stuff to expose to the user space at this point >> of time. >>> >>>>> When modifying/adding new sysfs stuff, you need a Documentation/ABI/ >>>>> entry as well. >>>> >>>> I'm not actually adding any new sysfs entry other than what a *class_create* >>>> must have created. Do I need to add one for that? >>> >>> If you are not creating anything in sysfs at all, why use the driver >>> model? (hint, I think you need to do something here to justify it...) >> >> Well.. it helps me to use pm_runtime to enable clocks utilizing the >> parent-child relationship. > > Ok, that's a good reason for this, nevermind then. Care to send the > latest patches you have in emails so I can review them? Sure. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/