Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756708Ab3GRHwM (ORCPT ); Thu, 18 Jul 2013 03:52:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56207 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815Ab3GRHwK (ORCPT ); Thu, 18 Jul 2013 03:52:10 -0400 Date: Thu, 18 Jul 2013 00:52:03 -0700 From: Andrew Morton To: "Yann E. MORIN" Cc: Geert Uytterhoeven , Sam Ravnborg , "H. Peter Anvin" , Ingo Molnar , Kyungsik Lee , Michal Marek , "linux-kernel@vger.kernel.org" , "linux-kbuild" , "the arch/x86 maintainers" , CE Linux Developers List , "linux-arm-kernel@lists.infradead.org" , hyojun.im@lge.com, chan.jeong@lge.com, Andy Lee , Ingo Molnar , Thomas Gleixner , Russell King , Borislav Petkov , Florian Fainelli , Yann Collet , Chanho Min Subject: Re: [PATCH -next 2/2] kbuild: fix for updated LZ4 tool with the new streaming format Message-Id: <20130718005203.9e9dc1d1.akpm@linux-foundation.org> In-Reply-To: <201307180947.02456.yann.morin.1998@free.fr> References: <1367829775-4434-1-git-send-email-kyungsik.lee@lge.com> <20130718003408.bb9d5b51.akpm@linux-foundation.org> <201307180947.02456.yann.morin.1998@free.fr> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 30 On Thu, 18 Jul 2013 09:47:02 +0200 "Yann E. MORIN" wrote: > > > > I prefer the "option exec" approach, actually. That way the shell-outs > > are colocated with the code which uses > > Indeed, but in this case, all the checks will be spread-out in the Kconfig > files, and not easily locatable. Having all in a single script will also > more easily raise eyebrows when that script appears in a diffstat. Noticing > the 'exec' option risks being a bit less easy. Eh, there are a million ways to screw up the kernel. > But, that's not my call to decide. ;-) > > > them and they will only be executed > > if you've actually selected that subsystem for building (I think?). > > If I understand the code correctly (which is still to be proven), the > exec option is run at parse-time, once. Yes, but not every Kconfig file in the tree gets parsed every time. For example, if arch/arm/Kconfig uses "option exec=some-slow-thing", x86 users won't execute some-slow-thing. This is good. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/